chore(vcpkg-ports): expose grpc feature in monitoring_system overlay port#571
Merged
Conversation
…port The project vcpkg.json defines a grpc feature (gRPC + protobuf for OTLP trace export), but the overlay port did not expose it. Consumers using the overlay port had no way to enable gRPC-based monitoring. Add the grpc feature to the port vcpkg.json with matching dependency versions (grpc >= 1.51.1, protobuf >= 3.21.0) and pass the MONITORING_WITH_GRPC flag through the portfile. Closes #570
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
…A512 (#514) Update the vcpkg overlay port for kcenon/thread_system: - REF: commit SHA 80242646 → annotated tag v0.3.0 - SHA512: placeholder '0' → actual archive hash The v0.3.0 tag was created in kcenon/thread_system after merging: - #571: fix(build) link common_system target for vcpkg find_package - #572: chore(release) bump version to 0.3.0 SHA512 was computed from the GitHub-generated source archive: https://github.com/kcenon/thread_system/archive/refs/tags/v0.3.0.tar.gz Resolves: kcenon/thread_system#570
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
…port (#571) The project vcpkg.json defines a grpc feature (gRPC + protobuf for OTLP trace export), but the overlay port did not expose it. Consumers using the overlay port had no way to enable gRPC-based monitoring. Add the grpc feature to the port vcpkg.json with matching dependency versions (grpc >= 1.51.1, protobuf >= 3.21.0) and pass the MONITORING_WITH_GRPC flag through the portfile. Closes #570
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Summary
Add the
grpcfeature to the monitoring_system overlay port (vcpkg-ports/kcenon-monitoring-system/), aligning the port with the projectvcpkg.jsonmanifest. PassMONITORING_WITH_GRPCthrough the portfile to enable gRPC-based OTLP trace export.Change Type
Why
Related Issues
Motivation
The project
vcpkg.jsondefines agrpcfeature for OTLP gRPC transport, but the overlay port did not expose it. Consumers installing viavcpkg install kcenon-monitoring-systemhad no way to enable gRPC support.Feature Alignment
loggingnetworkgrpctestingWhere
Files Changed
vcpkg-ports/kcenon-monitoring-system/vcpkg.jsongrpcfeature with dependenciesvcpkg-ports/kcenon-monitoring-system/portfile.cmakeHow
Implementation
grpcfeature to portvcpkg.jsonwithgrpc >= 1.51.1andprotobuf >= 3.21.0portfile.cmakethat setsMONITORING_WITH_GRPC_TRANSPORT-DMONITORING_WITH_GRPC=${MONITORING_WITH_GRPC_TRANSPORT}tovcpkg_cmake_configureTest Plan
vcpkg install kcenon-monitoring-system[grpc]should build with gRPC OTLP transportvcpkg install kcenon-monitoring-system(without grpc feature) should build without gRPCloggingandnetworkfeatures remain unaffected