fix(tests): enable metric exporters and opentelemetry adapter tests (ARC-001 Phase 1)#332
Merged
Merged
Conversation
- Update test_opentelemetry_adapter.cpp to use Result API patterns - Replace EXPECT_TRUE(result) with EXPECT_TRUE(result.is_ok()) - Replace EXPECT_FALSE(result) with EXPECT_TRUE(result.is_err()) - Fix error code comparisons to use static_cast<int>() - Update udp_transport.h to fix namespace issues - Close namespace before #include directives - Add using declaration for base class send method - Enable test_metric_exporters.cpp and test_opentelemetry_adapter.cpp in tests/CMakeLists.txt - Update comments for remaining disabled tests with required APIs This enables 2 of 4 disabled tests from ARC-001 Phase 1. Remaining tests require API implementation (tracked separately). Resolves partial work on #320
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
…332) - Update test_opentelemetry_adapter.cpp to use Result API patterns - Replace EXPECT_TRUE(result) with EXPECT_TRUE(result.is_ok()) - Replace EXPECT_FALSE(result) with EXPECT_TRUE(result.is_err()) - Fix error code comparisons to use static_cast<int>() - Update udp_transport.h to fix namespace issues - Close namespace before #include directives - Add using declaration for base class send method - Enable test_metric_exporters.cpp and test_opentelemetry_adapter.cpp in tests/CMakeLists.txt - Update comments for remaining disabled tests with required APIs This enables 2 of 4 disabled tests from ARC-001 Phase 1. Remaining tests require API implementation (tracked separately). Resolves partial work on #320
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Enabled Tests
is_ok()/is_err()patternsResult API Migration
Fixed Issues
Remaining Tests (Not in this PR)
The following tests require significant API implementation and are tracked separately:
Test Results
Test Plan
-DMONITORING_BUILD_TESTS=ON./tests/monitoring_system_testsPartially resolves #320