Summary
Fix 4 disabled test files that require Result API updates to restore test coverage. This is Phase 1 of ARC-001 (Low Test Coverage) resolution.
Related Architecture Issue
- ARC-001: Low Test Coverage (65% → 80% target)
- Phase 1 focuses on Result API migration tests
Current State
Location: tests/CMakeLists.txt:105-117
The following tests are disabled due to Result API changes:
| Test File |
Issue |
test_health_monitoring.cpp |
Result API updates needed |
test_fault_tolerance.cpp |
Result API updates needed |
test_metric_exporters.cpp |
monitoring_data type missing + Result API |
test_opentelemetry_adapter.cpp |
monitoring_data type missing + Result API |
Problem Analysis
API Migration Required
The codebase migrated from:
// Old pattern
result<T> res = some_function();
if (res) { auto val = res.value(); }
To:
// New pattern (common::Result<T>)
common::Result<T> res = some_function();
if (res.is_ok()) { auto val = res.value(); }
Missing Type: monitoring_data
Some tests reference monitoring_data type which was removed or renamed during API evolution.
Tasks
Acceptance Criteria
Priority
P0 (High) - Critical for test coverage improvement (ARC-001)
Migration Pattern Reference
// Before (deprecated)
auto result = health_monitor.check();
EXPECT_TRUE(result);
auto value = result.value();
// After (current API)
auto result = health_monitor.check();
EXPECT_TRUE(result.is_ok());
auto value = result.value();
// Error handling
if (result.is_err()) {
auto& error = result.error();
// handle error
}
References
include/kcenon/monitoring/core/result_types.h - Migration guide in comments
docs/advanced/MIGRATION_GUIDE_V2.md - Detailed migration instructions
- ARC-001 in
docs/advanced/ARCHITECTURE_ISSUES.md
Summary
Fix 4 disabled test files that require Result API updates to restore test coverage. This is Phase 1 of ARC-001 (Low Test Coverage) resolution.
Related Architecture Issue
Current State
Location:
tests/CMakeLists.txt:105-117The following tests are disabled due to Result API changes:
test_health_monitoring.cpptest_fault_tolerance.cpptest_metric_exporters.cppmonitoring_datatype missing + Result APItest_opentelemetry_adapter.cppmonitoring_datatype missing + Result APIProblem Analysis
API Migration Required
The codebase migrated from:
To:
Missing Type:
monitoring_dataSome tests reference
monitoring_datatype which was removed or renamed during API evolution.Tasks
test_health_monitoring.cppto useis_ok()/is_err()patterntest_fault_tolerance.cppto use new Result APImonitoring_datatype intest_metric_exporters.cpptest_opentelemetry_adapter.cppfor new APItests/CMakeLists.txtAcceptance Criteria
tests/CMakeLists.txtPriority
P0 (High) - Critical for test coverage improvement (ARC-001)
Migration Pattern Reference
References
include/kcenon/monitoring/core/result_types.h- Migration guide in commentsdocs/advanced/MIGRATION_GUIDE_V2.md- Detailed migration instructionsdocs/advanced/ARCHITECTURE_ISSUES.md