fix(interfaces): add full namespace qualification for cross-namespace usage#273
Merged
Merged
Conversation
… usage Add fully qualified namespace prefixes (::kcenon::common::) to types used in transport interface headers to prevent namespace resolution issues when headers are included from different namespace contexts. Changes: - http_client_interface.h: Qualify Result, make_error, error_codes - udp_client_interface.h: Qualify VoidResult, error_info, error_codes This fixes compilation errors when these headers are included from within kcenon::monitoring or other namespaces that may have their own 'common' namespace alias.
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
::kcenon::common::) to types used in transport interface headersChanges
http_client_interface.h: QualifyResult,make_error,error_codesinnull_http_clientudp_client_interface.h: QualifyVoidResult,error_info,error_codesinIUdpClientandnull_udp_clientProblem
When these headers are included from within different namespace contexts (e.g.,
kcenon::monitoring), the unqualified type names are resolved relative to the current namespace, causing compilation errors like:Solution
Use absolute namespace paths with leading
::to ensure correct resolution regardless of inclusion context.Testing
Related