Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

CI: Make static check ignore local URLs#838

Merged
chavafg merged 1 commit intokata-containers:masterfrom
jodh-intel:ci-static-check-ignore-file-urls
Oct 23, 2018
Merged

CI: Make static check ignore local URLs#838
chavafg merged 1 commit intokata-containers:masterfrom
jodh-intel:ci-static-check-ignore-file-urls

Conversation

@jodh-intel
Copy link
Copy Markdown

@jodh-intel jodh-intel commented Oct 23, 2018

Update the static check script to ignore file:// URLs which won't
exist (since they only appear in examples).

Fixes #837.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

@jodh-intel
Copy link
Copy Markdown
Author

jodh-intel commented Oct 23, 2018

This is blocking kata-containers/documentation#272.

@jodh-intel jodh-intel mentioned this pull request Oct 23, 2018
Merged
grahamwhaley
grahamwhaley approved these changes Oct 23, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jodh-intel
Copy link
Copy Markdown
Author

jodh-intel commented Oct 23, 2018

/test

@grahamwhaley
Copy link
Copy Markdown
Contributor

grahamwhaley commented Oct 23, 2018

Now we have #839 (force) merged, let's tickle this and see if it worked....
/test

@grahamwhaley
Copy link
Copy Markdown
Contributor

grahamwhaley commented Oct 23, 2018

Ah, maybe as this is a PR in the tests repo, it would need a rebase before it took on #839 :-(

/tmp/jenkins/workspace/kata-containers-tests-ubuntu-16-04-PR-initrd/go/src/github.com/kata-containers/tests/stress
versions.yaml
  7:1       warning  missing document start "---"  (document-start)

INFO: Installing xurls utility
package mvdan.cc/xurls/v2: cannot find package "mvdan.cc/xurls/v2" in any of:
	/usr/local/go/src/mvdan.cc/xurls/v2 (from $GOROOT)
	/tmp/jenkins/workspace/kata-containers-tests-ubuntu-16-04-PR-initrd/go/src/mvdan.cc/xurls/v2 (from $GOPATH)
Build step 'Execute shell' marked build as failure

This PR was triggered for a rebuild, let's watch that one @jodh-intel and your newly kicked kata-containers/documentation#280 as well.....

@jodh-intel jodh-intel force-pushed the ci-static-check-ignore-file-urls branch from cd2051b to 38299fd Compare October 23, 2018 10:05
CI: Make static check ignore local URLs
edf8474 
Update the static check script to ignore `file://` URLs which won't
exist (since they only appear in examples).

Fixes kata-containers#837.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel jodh-intel force-pushed the ci-static-check-ignore-file-urls branch from 38299fd to edf8474 Compare October 23, 2018 14:20
@jodh-intel
Copy link
Copy Markdown
Author

jodh-intel commented Oct 23, 2018

/test

@jodh-intel jodh-intel mentioned this pull request Oct 23, 2018
Closed
@chavafg
Copy link
Copy Markdown
Contributor

chavafg commented Oct 23, 2018

saw some docker failures on the initrd job. Not related to this PR so relaunching job...

Summarizing 5 Failures:

[Fail] Hotplug memory when create containers Hotplug memory when create containers [It] hotplug memory when create containers should not fail 
/tmp/jenkins/workspace/kata-containers-tests-ubuntu-16-04-PR-initrd/go/src/github.com/kata-containers/tests/integration/docker/mem_test.go:74

[Fail] docker privileges [AfterEach] check no-new-privileges flag should display the correct uid 
/tmp/jenkins/workspace/kata-containers-tests-ubuntu-16-04-PR-initrd/go/src/github.com/kata-containers/tests/integration/docker/privileges_test.go:34

[Fail] docker volume remove bind-mount source before container exits [It] should exit cleanly without leaking process 
/tmp/jenkins/workspace/kata-containers-tests-ubuntu-16-04-PR-initrd/go/src/github.com/kata-containers/tests/integration/docker/volume_test.go:175

[Fail] load [AfterEach] load with docker load a container should load image 
/tmp/jenkins/workspace/kata-containers-tests-ubuntu-16-04-PR-initrd/go/src/github.com/kata-containers/tests/integration/docker/load_test.go:26

[Fail] docker commit commit a container with new configurations [It] should have the new configurations 
/tmp/jenkins/workspace/kata-containers-tests-ubuntu-16-04-PR-initrd/go/src/github.com/kata-containers/tests/integration/docker/commit_test.go:41

@jodh-intel
Copy link
Copy Markdown
Author

jodh-intel commented Oct 23, 2018

I'm going to suggest we just merge this:

  • the ARM CI failed but we know it's broken atm.
  • the jenkins-ci-ubuntu-16-04-initrd CI failed but the failure cannot be related to this PR which would only affect doc changes (of which there are none on this PR :)

Takers... ? :)

@jodh-intel
Copy link
Copy Markdown
Author

jodh-intel commented Oct 23, 2018

We'll then be unblocking kata-containers/documentation#272.

@chavafg
Copy link
Copy Markdown
Contributor

chavafg commented Oct 23, 2018 •
edited by amshinde
Loading

lgtm

Approved with PullApprove

@chavafg
Copy link
Copy Markdown
Contributor

chavafg commented Oct 23, 2018

pullapprove not working...
I'll merge as the ubuntu-initrd job has already passed and there are acks from @grahamwhaley and myself.

@chavafg chavafg merged commit 0341cc1 into kata-containers:master Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@grahamwhaley grahamwhaley grahamwhaley approved these changes

@chavafg chavafg chavafg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jodh-intel @grahamwhaley @chavafg