This repository was archived by the owner on Jun 28, 2024. It is now read-only.
Merged
Conversation
The `xurls` tool used by the static checker seems to have changed its URL so switch to the (hopefully more reliable!) github one. Fixes: kata-containers#835. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Author
|
Replaces #836. |
Closed
Author
|
/test |
Author
|
ARM CI failure can be ignored for now as it's currently borked (kata-containers/ci#74). |
Contributor
|
Boom boom boom... CI's not happy: |
Author
|
It looks like the CI scripts are using the current (incorrect) version of this script this PR changes so we're going to have to force-merge this one @grahamwhaley I think. |
grahamwhaley
approved these changes
Oct 23, 2018
Contributor
grahamwhaley
left a comment
There was a problem hiding this comment.
I'm prone to say.... it can't really make it any worse (or not right now).... and you tested the cmd locally to check it did actually pull the repo, so:
lgtm
go force @jodh-intel
Contributor
|
Have forced - now let me go find another PR to tickle to check if it worked..... |
jodh-intel
pushed a commit
to jodh-intel/tests-1
that referenced
this pull request
Oct 23, 2018
Undo URL change from [1] since the xurls install issue was caused by the CI using a version of golang that is too old for xurls. Fixes kata-containers#841. --- [1] - kata-containers#839 Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
pushed a commit
to jodh-intel/tests-1
that referenced
this pull request
Oct 23, 2018
Undo URL change from [1] since the xurls install issue was caused by the CI using a version of golang that is too old for xurls. Fixes kata-containers#841. --- [1] - kata-containers#839 Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
pushed a commit
to jodh-intel/tests-1
that referenced
this pull request
Oct 23, 2018
Undo URL change from [1] since the xurls install issue was caused by the CI using a version of golang that is too old for xurls. Fixes kata-containers#841. --- [1] - kata-containers#839 Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
xurlstool used by the static checker seems to have changed itsURL so switch to the (hopefully more reliable!) github one.
Fixes: #835.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com