Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

install: Add AWS installation guide#272

Merged
egernst merged 1 commit intokata-containers:masterfrom
raravena80:master
Oct 26, 2018
Merged

install: Add AWS installation guide#272
egernst merged 1 commit intokata-containers:masterfrom
raravena80:master

Conversation

@raravena80
Copy link
Copy Markdown
Member

@raravena80 raravena80 commented Oct 17, 2018

Installation guide for AWS.

cc: @annabellebertooch

Signed-off-by: Ricardo Aravena raravena@branch.io

jodh-intel
jodh-intel reviewed Oct 17, 2018
View reviewed changes
Copy link
Copy Markdown

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raravena80 - Thanks for raising - this is going to be a really useful resource!

I've added a few comments mostly around consistency with our existing docs.

Also, Travis is failing since our checkcommits tool is complaining there is no "Fixes #XXX" comment in you commit, and pointing you to:

I've raised #273 for you so can amend your commit to include a Fixes #273 and re-push.

marcov
marcov reviewed Oct 17, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@marcov marcov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raravena80, thanks for the new guide.

Can you also add a link to this document in Installing on a cloud service platform?

@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Oct 17, 2018

Hi @raravena80 - I forgot to say, could you also add a link to the new AWS doc to the following on this PR:

@raravena80
Copy link
Copy Markdown
Member Author

raravena80 commented Oct 17, 2018 •
edited
Loading

@jodh-intel @marcov made the changes and also added a link to it from https://github.com/kata-containers/documentation/blob/master/install/README.md#installing-on-a-cloud-service-platform. PTAL. Thx!

Looks like travis is failing with:

package mvdan.cc/xurls/cmd/xurls: unrecognized import path "mvdan.cc/xurls/cmd/xurls" (https fetch: Get https://mvdan.cc/xurls/cmd/xurls?go-get=1: dial tcp 178.62.67.243:443: i/o timeout)```

And shell code invalid. I can't find which is one is actually failing on.

nmeyerhans
nmeyerhans reviewed Oct 17, 2018
View reviewed changes
@raravena80 raravena80 force-pushed the master branch 2 times, most recently from 46acd78 to 6fa8655 Compare October 17, 2018 18:13
jodh-intel
jodh-intel reviewed Oct 18, 2018
View reviewed changes
@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Oct 19, 2018 •
edited by amshinde
Loading

Thanks @raravena80.

We can always finesse the doc to use jq at a later date. I think it's more important that we land it so...

lgtm

Approved with PullApprove Approved with PullApprove

jodh-intel
jodh-intel reviewed Oct 19, 2018
View reviewed changes
Copy link
Copy Markdown

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raravena80 - I should have looked at the bottom of the page first :) The CI is failing and I've made a few suggestions as to how to resolve that.

@grahamwhaley
Copy link
Copy Markdown
Contributor

grahamwhaley commented Oct 19, 2018

Did the travis doc processing get fixed? I still see:

INFO: processing file 'install/aws-installation-guide.md'
ERROR: shell code in file 'install/aws-installation-guide.md' is not valid

@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Oct 19, 2018

@grahamwhaley - see #272 (comment).

@raravena80
Copy link
Copy Markdown
Member Author

raravena80 commented Oct 19, 2018

@jodh-intel @grahamwhaley looks like now it thinks file://MyKeyPair.pub should be a URL:

ERROR: Invalid URL 'file://MyKeyPair.pub' found in the following files:

@grahamwhaley
Copy link
Copy Markdown
Contributor

grahamwhaley commented Oct 19, 2018

@raravena80 :-) - looks like an URL on my screen ;-) /me leaves it for @jodh-intel to contemplate..

@raravena80
Copy link
Copy Markdown
Member Author

raravena80 commented Oct 22, 2018

@jodh-intel any updates?

This was referenced Oct 23, 2018
Closed
Merged
@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Oct 23, 2018

@raravena80 - That issue is fixed on kata-containers/tests#838.

jodh-intel
jodh-intel reviewed Oct 23, 2018
View reviewed changes
jodh-intel
jodh-intel reviewed Oct 24, 2018
View reviewed changes
@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Oct 24, 2018

kata-containers/tests#838 has now landed so this should pass the CI now. Let's see...

lgtm

/test

@raravena80
install: Add AWS installation guide
942d534 
Fixes kata-containers#273

Installation guide for AWS.

Signed-off-by: Ricardo Aravena <raravena@branch.io>
@egernst egernst merged commit a184f98 into kata-containers:master Oct 26, 2018
devimc pushed a commit to devimc/kata-documentation that referenced this pull request Sep 2, 2019
@GabyCT
Merge pull request kata-containers#272 from devimc/topic/fsFeatures
edd7d9c 
image-builder: share the mkfs configuration file
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

5 more reviewers

@marcov marcov marcov left review comments

@nmeyerhans nmeyerhans nmeyerhans left review comments

@grahamwhaley grahamwhaley grahamwhaley left review comments

@jodh-intel jodh-intel jodh-intel left review comments

@egernst egernst egernst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@raravena80 @jodh-intel @grahamwhaley @marcov @nmeyerhans @egernst