This repository was archived by the owner on May 12, 2021. It is now read-only.
factory: set guest time after resuming#976
Merged
lifupan merged 2 commits intokata-containers:masterfrom Dec 12, 2018
Merged
Conversation
Member
Author
|
/test |
|
lgtm We should really add an integration test to ensure that when VM templating is enabled, the guest time progresses as expected. |
|
lgtm |
Member
|
Assuming you will be adding the commit list in your vendor commit, this As @jodh-intel pointed, will be useful to have an integration test for this. |
bergwolf
added a commit
to bergwolf/kata-tests
that referenced
this pull request
Dec 5, 2018
Make sure it is not affected by being created from vm template. Depends-on: github.com/kata-containers/agent#425 Depends-on: github.com/kata-containers/runtime#976 Fixes: kata-containers#968 Signed-off-by: Peng Tao <bergwolf@gmail.com>
Member
Author
|
Sure @jodh-intel . Please see kata-containers/tests#969 |
Full commit list: 34b7454 grpc: sandbox: add container when is fully created. df822eb grpc: support rlimits 87ad0a8 release: Kata Containers 1.5.0-rc1 31c6b6e grpc: add SetGuestDateTime API 4eca13b client: do cleanup after UT stop mock server c25288a Makefile: Decide if agent will be built by seccomp tag 0aae82b release: Kata Containers 1.4.0 7b4c337 vendor: Update vendor/github.com/containerd/console 8dedf30 agent: build as Position-Independent-Executable dc635d4 test: Add test for ipvlan routes in l3 mode 69ee60f network: Refactor to reduce cyclomatic complexity 4005c33 network: Handle default route where gateway is empty 83138df pkg: types: Add a new field type Signed-off-by: Peng Tao <bergwolf@gmail.com>
We might have paused a guest for a long time so we need to sync its time. Fixes:kata-containers#951 Signed-off-by: Peng Tao <bergwolf@gmail.com>
Member
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We might have paused a guest for a long time so we need to sync its time.
depends on kata-containers/agent#425