This repository was archived by the owner on Jun 28, 2024. It is now read-only.
vm_factory: add tests to check new vm time#969
Merged
teawater merged 1 commit intokata-containers:masterfrom Dec 13, 2018
Merged
vm_factory: add tests to check new vm time#969teawater merged 1 commit intokata-containers:masterfrom
teawater merged 1 commit intokata-containers:masterfrom
Conversation
Member
Author
|
/test |
|
Thanks @bergwolf ! lgtm |
chavafg
approved these changes
Dec 7, 2018
Contributor
chavafg
left a comment
There was a problem hiding this comment.
lgtm
will add a DNM label so we don't merge it until kata-containers/agent#425 and kata-containers/runtime#976 are merged.
Member
Author
|
/retest |
Make sure it is not affected by being created from vm template. Fixes: kata-containers#968 Signed-off-by: Peng Tao <bergwolf@gmail.com>
dfbfbdb to
cd2f408
Compare
Member
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure it is not affected by being created from vm template.
Depends-on: github.com/kata-containers/agent#425
Depends-on: github.com/kata-containers/runtime#976
Fixes: #968