versions: Update golang to 1.10.4 by jodh-intel · Pull Request #744 · kata-containers/runtime

jodh-intel · 2018-09-18T11:19:52Z

Move to golang version 1.10.4 -- the oldest stable golang release at the
time of writing -- since golang 1.10+ is needed to make namespace
handling safe.

See:

Also bumped languages.golang.meta.newest-version to golang version
1.11, which is the newest stable release at the time of writing.

Fixes #148.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

katacontainersbot · 2018-09-18T11:33:51Z

PSS Measurement:
Qemu: 162533 KB
Proxy: 4509 KB
Shim: 9259 KB

Memory inside container:
Total Memory: 2043460 KB
Free Memory: 2006704 KB

grahamwhaley

lgtm

grahamwhaley · 2018-09-18T12:21:58Z

But I think it blew the CIs... for instance, Centos 7.4:

virtcontainers/monitor.go:15:14:warning: struct of size 80 could be 72 (maligned)
virtcontainers/pkg/mock/cc_proxy_mock.go:24:18:warning: struct of size 160 could be 152 (maligned)
Build step 'Execute shell' marked build as failure

egernst · 2018-09-18T14:28:18Z

Like the idea - let's see if the CI can be agreeable.

caoruidong · 2018-09-18T15:52:46Z

I think this can only be fixed by reordering field in this structs.

sboeuf

@jodh-intel looks good to me, but you need to rework some of the Go structures there if you want to make maligned happy ;)

caoruidong · 2018-09-20T02:23:34Z

+1. Due to golang release policy, 1.9 is not supported since 1.11 is released.

gnawux · 2018-09-20T07:48:47Z

lgtm

I think the maligned crying is not related to this patch, right?

jodh-intel · 2018-09-20T13:30:11Z

/me tweaks branch to hopefully stop the linters bleating...

katacontainersbot · 2018-09-20T13:41:40Z

PSS Measurement:
Qemu: 166579 KB
Proxy: 4398 KB
Shim: 9303 KB

Memory inside container:
Total Memory: 2043460 KB
Free Memory: 2006892 KB

jodh-intel · 2018-09-20T13:51:15Z

CI failed due to a factory test failure:

--- FAIL: TestNewFactory (0.01s)
    testing.go:771: race detected during execution of test

==================
WARNING: DATA RACE
Read at 0x00c0000301e8 by goroutine 7:
  internal/race.Read()
      /usr/local/go/src/internal/race/race.go:37 +0x38
  sync.(*WaitGroup).Add()
      /usr/local/go/src/sync/waitgroup.go:71 +0x16b
  github.com/kata-containers/runtime/virtcontainers/factory/cache.New()
      /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-16-04-PR/go/src/github.com/kata-containers/runtime/virtcontainers/factory/cache/cache.go:37 +0x176
  github.com/kata-containers/runtime/virtcontainers/factory.NewFactory()
      /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-16-04-PR/go/src/github.com/kata-containers/runtime/virtcontainers/factory/factory.go:73 +0x385
  github.com/kata-containers/runtime/virtcontainers/factory.TestNewFactory()
      /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-16-04-PR/go/src/github.com/kata-containers/runtime/virtcontainers/factory/factory_test.go:60 +0x759
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:827 +0x162

Previous write at 0x00c0000301e8 by goroutine 9:
  internal/race.Write()
      /usr/local/go/src/internal/race/race.go:41 +0x38
  sync.(*WaitGroup).Wait()
      /usr/local/go/src/sync/waitgroup.go:128 +0xef
  github.com/kata-containers/runtime/virtcontainers/factory/cache.(*cache).CloseFactory.func1()
      /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-16-04-PR/go/src/github.com/kata-containers/runtime/virtcontainers/factory/cache/cache.go:80 +0x129
  sync.(*Once).Do()
      /usr/local/go/src/sync/once.go:44 +0xde
  github.com/kata-containers/runtime/virtcontainers/factory/cache.(*cache).CloseFactory()
      /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-16-04-PR/go/src/github.com/kata-containers/runtime/virtcontainers/factory/cache/cache.go:76 +0x7a
  github.com/kata-containers/runtime/virtcontainers/factory/cache.New.func1()
      /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-16-04-PR/go/src/github.com/kata-containers/runtime/virtcontainers/factory/cache/cache.go:43 +0x28b

Goroutine 7 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:878 +0x650
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1119 +0xa8
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:827 +0x162
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1117 +0x4ee
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1034 +0x2ee
  main.main()
      _testmain.go:98 +0x332

Goroutine 9 (finished) created at:
  github.com/kata-containers/runtime/virtcontainers/factory/cache.New()
      /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-16-04-PR/go/src/github.com/kata-containers/runtime/virtcontainers/factory/cache/cache.go:38 +0x1e0
  github.com/kata-containers/runtime/virtcontainers/factory.NewFactory()
      /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-16-04-PR/go/src/github.com/kata-containers/runtime/virtcontainers/factory/factory.go:73 +0x385
  github.com/kata-containers/runtime/virtcontainers/factory.TestNewFactory()
      /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-16-04-PR/go/src/github.com/kata-containers/runtime/virtcontainers/factory/factory_test.go:60 +0x759
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:827 +0x162
==================

/cc @bergwolf.

katacontainersbot · 2018-09-20T14:13:22Z

PSS Measurement:
Qemu: 170312 KB
Proxy: 4487 KB
Shim: 9131 KB

Memory inside container:
Total Memory: 2043460 KB
Free Memory: 2006828 KB

jodh-intel · 2018-09-20T15:00:45Z

Sigh - go 1.10 is spotting issues in other projects code and failing our tests ;((

# github.com/containerd/cri/integration
integration/image_load_test.go:39: T.Skip call has possible formatting directive %v

jodh-intel · 2018-09-25T14:39:33Z

/test

jodh-intel · 2018-09-25T14:40:14Z

/me watches the CI turbines start spinning...

katacontainersbot · 2018-09-25T15:01:58Z

PSS Measurement:
Qemu: 166263 KB
Proxy: 4536 KB
Shim: 9301 KB

Memory inside container:
Total Memory: 2043448 KB
Free Memory: 2006820 KB

grahamwhaley · 2018-10-01T13:42:45Z

CI turbines bombed @jodh-intel Is this still something you will pursue?

bergwolf · 2018-10-09T03:47:14Z

@jodh-intel Any updates?

grahamwhaley · 2018-10-09T08:47:30Z

@bergwolf See #806 - @amshinde has posted some patches upstream to containerd/cri - we need to get them pulled in so we can bump the golang version and not fail the build.

bergwolf · 2018-10-10T02:21:21Z

@grahamwhaley Are you referring to containerd/cri#941 ? It is already merged. Now we can update cri/containerd dependency and then bump golang version. cc @jodh-intel

grahamwhaley · 2018-10-10T08:28:09Z

@bergwolf - yes, that is the merged PR. Over on #806 I have the patches to bump that versions.yaml and golang version change. I'll chase that up - I need to fix at least the yq dep for travis.

raravena80 · 2018-10-22T16:40:35Z

@jodh-intel ping from your weekly Kata herder.

jodh-intel · 2018-10-23T11:19:40Z

/test

jodh-intel · 2018-10-23T11:29:56Z

/test

jodh-intel · 2018-10-23T11:32:21Z

/test

Updated `externals.cri-containerd.version` in `versions.yaml` to the newest version that includes the fix for building on golang 1.10.2: - https://github.com/containerd/cri/commits/8b0d53c09c41d9fbc3b3896548ecf011518e3c42 Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>

Move to golang version 1.10.4 -- the oldest stable golang release at the time of writing -- since golang 1.10+ is needed to make namespace handling safe. Re-ordered a couple of structs (moved `sync.WaitGroup` fields) to keep the `maligned` linter happy. Previously: `` virtcontainers/pkg/mock/cc_proxy_mock.go:24:18:warning: struct of size 160 could be 152 (maligned) virtcontainers/monitor.go:15:14:warning: struct of size 80 could be 72 (maligned) ``` See: - golang/go#20676 - golang/go@2595fe7 Also bumped `languages.golang.meta.newest-version` to golang version 1.11, which is the newest stable release at the time of writing. Fixes kata-containers#148. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>

jodh-intel · 2018-10-23T13:21:19Z

/test

jodh-intel · 2018-10-23T13:40:08Z

We now have a cyclic dependency since this PR is failing due to kata-containers/tests#843 (and vice versa).

grahamwhaley

This still:
lgtm

grahamwhaley · 2018-10-23T13:56:04Z

OK, we know this will fail on the xurl stuff, which we need to land this to fix:

INFO: Installing xurls utility
package mvdan.cc/xurls/v2: cannot find package "mvdan.cc/xurls/v2" in any of:
	/usr/local/go/src/mvdan.cc/xurls/v2 (from $GOROOT)
	/tmp/jenkins/workspace/kata-containers-runtime-ubuntu-16-04-PR/go/src/mvdan.cc/xurls/v2 (from $GOPATH)
Build step 'Execute shell' marked build as failure

@jodh-intel and I propose we force merge. Of course it carries some risk, but right now the CI is broken on the xurl item, and we can merge nothing else anyway...

Travis appears to be providing a version of golang that is too old for https://mvdan.cc/xurls/cmd/xurls, which is used by the CI scripts in the tests repo. See: - kata-containers/runtime#744 - kata-containers/tests#843 (comment) Fixes kata-containers#281. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>

Travis appears to be providing a version of golang that is too old for https://mvdan.cc/xurls/cmd/xurls, which is used by the CI scripts in the tests repo. See: - kata-containers/runtime#744 - kata-containers/tests#843 (comment) Required adding a NOP makefile to avoid Travis from trying to build this repo using `go`. Fixes kata-containers#281. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>

grahamwhaley approved these changes Sep 18, 2018

View reviewed changes

sboeuf approved these changes Sep 18, 2018

View reviewed changes

jodh-intel force-pushed the update-to-golang-1.10.4 branch from 071c640 to 717b08c Compare September 20, 2018 13:29

jodh-intel force-pushed the update-to-golang-1.10.4 branch from 717b08c to 67979b4 Compare September 20, 2018 13:57

grahamwhaley mentioned this pull request Oct 4, 2018

build: check golang version meets min req. #806

Merged

jodh-intel mentioned this pull request Oct 23, 2018

CI: Really fix xurls URL issue kata-containers/tests#843

Closed

jodh-intel force-pushed the update-to-golang-1.10.4 branch from 67979b4 to a6f5464 Compare October 23, 2018 11:19

jodh-intel force-pushed the update-to-golang-1.10.4 branch from a6f5464 to 33aefe8 Compare October 23, 2018 11:29

jodh-intel force-pushed the update-to-golang-1.10.4 branch from 33aefe8 to 986ba30 Compare October 23, 2018 11:32

James O. D. Hunt added 2 commits October 23, 2018 14:20

jodh-intel force-pushed the update-to-golang-1.10.4 branch from 986ba30 to 526d55b Compare October 23, 2018 13:20

grahamwhaley approved these changes Oct 23, 2018

View reviewed changes

grahamwhaley merged commit f3ef220 into kata-containers:master Oct 23, 2018

jodh-intel mentioned this pull request Oct 23, 2018

Pin Travis to golang 1.10.x kata-containers/documentation#281

Closed

jodh-intel mentioned this pull request Oct 23, 2018

CI: Pin Travis golang version kata-containers/documentation#282

Merged

This was referenced Oct 25, 2018

Handling of dependencies and forks kata-containers/kata-containers#32

Closed

versions: Add xurls utility #855

Closed

Conversation

jodh-intel commented Sep 18, 2018

Uh oh!

katacontainersbot commented Sep 18, 2018

Uh oh!

grahamwhaley left a comment

Choose a reason for hiding this comment

Uh oh!

grahamwhaley commented Sep 18, 2018

Uh oh!

egernst commented Sep 18, 2018

Uh oh!

caoruidong commented Sep 18, 2018

Uh oh!

sboeuf left a comment

Choose a reason for hiding this comment

Uh oh!

caoruidong commented Sep 20, 2018

Uh oh!

gnawux commented Sep 20, 2018 • edited by amshinde Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jodh-intel commented Sep 20, 2018

Uh oh!

katacontainersbot commented Sep 20, 2018

Uh oh!

jodh-intel commented Sep 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

katacontainersbot commented Sep 20, 2018

Uh oh!

jodh-intel commented Sep 20, 2018

Uh oh!

jodh-intel commented Sep 25, 2018

Uh oh!

jodh-intel commented Sep 25, 2018

Uh oh!

katacontainersbot commented Sep 25, 2018

Uh oh!

grahamwhaley commented Oct 1, 2018

Uh oh!

bergwolf commented Oct 9, 2018

Uh oh!

grahamwhaley commented Oct 9, 2018

Uh oh!

bergwolf commented Oct 10, 2018

Uh oh!

grahamwhaley commented Oct 10, 2018

Uh oh!

raravena80 commented Oct 22, 2018

Uh oh!

jodh-intel commented Oct 23, 2018

Uh oh!

jodh-intel commented Oct 23, 2018

Uh oh!

jodh-intel commented Oct 23, 2018

Uh oh!

jodh-intel commented Oct 23, 2018

Uh oh!

jodh-intel commented Oct 23, 2018

Uh oh!

grahamwhaley left a comment

Choose a reason for hiding this comment

Uh oh!

grahamwhaley commented Oct 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

gnawux commented Sep 20, 2018 •

edited by amshinde

Loading

jodh-intel commented Sep 20, 2018 •

edited

Loading