Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

test: Fix compile error with go1.10.2#941

Merged
Random-Liu merged 1 commit intocontainerd:masterfrom
amshinde:fix-go-compile-error
Oct 8, 2018
Merged

test: Fix compile error with go1.10.2#941
Random-Liu merged 1 commit intocontainerd:masterfrom
amshinde:fix-go-compile-error

Conversation

@amshinde
Copy link
Copy Markdown
Contributor

@amshinde amshinde commented Oct 8, 2018

Replace Skip with Skipf in the intergration test.

Signed-off-by: Archana Shinde archana.m.shinde@intel.com

@amshinde
test: Fix compile error with go1.10.2
54b1c00 
Replace Skip with Skipf in the intergration test.

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Oct 8, 2018

Hi @amshinde. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mikebrow
mikebrow approved these changes Oct 8, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM
Thanks!

@Random-Liu
Copy link
Copy Markdown
Member

Random-Liu commented Oct 8, 2018

/lgtm

The failure is caused by golang version issue. I'll update the test-infra.

@Random-Liu
Copy link
Copy Markdown
Member

Random-Liu commented Oct 8, 2018

Let's wait for kubernetes/test-infra#9736.

@amshinde
Copy link
Copy Markdown
Contributor Author

amshinde commented Oct 8, 2018

@Random-Liu I see the pull-cri-containerd-verify tests failing. Do these need to be rerun or is this a valid failure?

@Random-Liu
Copy link
Copy Markdown
Member

Random-Liu commented Oct 8, 2018

/test pull-cri-containerd-verify

@Random-Liu Random-Liu merged commit 8b0d53c into containerd:master Oct 8, 2018
@amshinde amshinde mentioned this pull request Oct 9, 2018
Merged
@bergwolf bergwolf mentioned this pull request Oct 10, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mikebrow mikebrow mikebrow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Random-Liu Random-Liu

@mikebrow mikebrow

Labels

lgtm needs-ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amshinde @k8s-ci-robot @Random-Liu @mikebrow