Skip to content

Use go 1.10 for containerd go verify.#9736

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Random-Liu:use-go-1.10-for-containerd-verify
Oct 8, 2018
Merged

Use go 1.10 for containerd go verify.#9736
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Random-Liu:use-go-1.10-for-containerd-verify

Conversation

@Random-Liu
Copy link
Copy Markdown
Member

@Random-Liu Random-Liu commented Oct 8, 2018

Containerd is still using go 1.10.
Signed-off-by: Lantao Liu lantaol@google.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2018
@k8s-ci-robot k8s-ci-robot requested a review from dchen1107 October 8, 2018 20:45
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config labels Oct 8, 2018
@BenTheElder
Copy link
Copy Markdown
Member

Containerd is still using go 1.11.

did you mean go 1.10? also note kubernetes master branch is now on go 1.11

- image: gcr.io/k8s-testimages/kubekins-e2e:v20181005-fd9cfb8b0-master
# TODO(random-liu): Update to gcr.io/k8s-testimages/kubekins-e2e:v20181005-fd9cfb8b0-master
# after containerd is updated to go 1.11.
- image: gcr.io/k8s-testimages/kubekins-e2e:v20181002-3e479534e-master
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this image has go 1.11 FYI

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which image I should use then?

@Random-Liu
Copy link
Copy Markdown
Member Author

did you mean go 1.10? also note kubernetes master branch is now on go 1.11

Yeah, 1.10. This only updates the verify job, we have to use 1.10 now until containerd is updated to 1.11. And kubernetes won't be affected, we don't build it in the job.

Signed-off-by: Lantao Liu <lantaol@google.com>
@Random-Liu Random-Liu force-pushed the use-go-1.10-for-containerd-verify branch from 005dbd6 to c98c5eb Compare October 8, 2018 21:25
Copy link
Copy Markdown
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2a609b2 into kubernetes:master Oct 8, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@Random-Liu: Updated the job-config configmap using the following files:

  • key containerd-cri-presubmit-jobs.yaml using file config/jobs/containerd/cri/containerd-cri-presubmit-jobs.yaml
Details

In response to this:

Containerd is still using go 1.10.
Signed-off-by: Lantao Liu lantaol@google.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants