vendor: update govmm and agent to support memory update by linzichang · Pull Request #669 · kata-containers/runtime

linzichang · 2018-08-30T08:11:18Z

vendor: update govmm and agent to support memory update
Fixes #671 

To support kata-runtime update memory, need separate CPU/memory in agent grpc handler
and handler query-memory-devices QMP commands in govmm.

1.Implement query-memory-devices QMP commands(govmm).
2.Add "CpuOnly" field to onlineCPUMem grpc request(agent).

govmm Shortlog:
b16291c qemu/qmp: support query-memory-devices qmp command.

agent Shortlog:
74a5364 build: fix make proto error
b1c2ad8 agent: add support for online memory and cpu separately.

Signed-off-by: Zichang Lin <linzichang@huawei.com>
Signed-off-by: Clare Chen <clare.chenhui@huawei.com>

linzichang · 2018-08-30T08:11:56Z

Related to #624

opendev-zuul · 2018-08-30T08:33:19Z

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

kata-runsh : RETRY_LIMIT in 9m 52s

jodh-intel · 2018-08-30T09:05:23Z

lgtm but build failing. From Travis:

../virtcontainers/qemu.go:862:53: not enough arguments in call to q.qmpMonitorCh.qmp.ExecuteNetPCIDeviceAdd
	have ("context".Context, string, string, string, string, string)
	want ("context".Context, string, string, string, string, string, int)

opendev-zuul · 2018-08-30T11:09:41Z

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

kata-runsh : TIMED_OUT in 1h 00m 55s

opendev-zuul · 2018-08-30T11:43:18Z

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

kata-runsh : RETRY_LIMIT in 6m 23s

katacontainersbot · 2018-08-30T12:21:40Z

PSS Measurement:
Qemu: 165712 KB
Proxy: 4036 KB
Shim: 8818 KB

Memory inside container:
Total Memory: 2043464 KB
Free Memory: 2003680 KB

devimc · 2018-08-30T13:24:56Z

@lifupan please take a look #651 (#651 (comment))

cc @caoruidong @woshijpf

codecov · 2018-08-30T13:32:46Z

Codecov Report

Merging #669 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
+ Coverage   65.24%   65.32%   +0.08%     
==========================================
  Files          85       85              
  Lines        9846     9846              
==========================================
+ Hits         6424     6432       +8     
+ Misses       2765     2758       -7     
+ Partials      657      656       -1

linzichang · 2018-08-31T02:11:14Z

CI is failed. I think there are some problems in CI environment, unrelated to my change.

caoruidong · 2018-08-31T02:15:43Z

We have a issue track this failure. kata-containers/tests#680

WeiZhang555 · 2018-08-31T03:06:40Z

This is duplicate of #649

#649 is updating the govmm, is there any dependency for govmm in this PR? If not I think you can update only the agent

katacontainersbot · 2018-08-31T03:15:33Z

PSS Measurement:
Qemu: 169567 KB
Proxy: 4243 KB
Shim: 8792 KB

Memory inside container:
Total Memory: 2043464 KB
Free Memory: 2003448 KB

linzichang · 2018-08-31T03:38:28Z

@WeiZhang555 This PR need govmm and agent update. And the govmm update is newly that #649 . Two choose:

Merge vendor: update govmm to be compatible with qemu 2.8 #649 first, then I make a rebase on this PR.
Close vendor: update govmm to be compatible with qemu 2.8 #649 , just merge this PR.

opendev-zuul · 2018-08-31T04:05:28Z

Build succeeded (third-party-check pipeline).

kata-runsh : SUCCESS in 58m 44s

jshachm · 2018-08-31T06:01:47Z

PLZ rebase this. #649 is just going to be merged~

Besides each commit should be clear enough to point the change. Just update the agent is better.

jodh-intel · 2018-08-31T10:42:44Z

yep - #649 is now merged so this needs a rebase.

katacontainersbot · 2018-09-03T01:49:05Z

PSS Measurement:
Qemu: 169921 KB
Proxy: 4076 KB
Shim: 8936 KB

Memory inside container:
Total Memory: 2043464 KB
Free Memory: 2003580 KB

katacontainersbot · 2018-09-03T02:04:28Z

PSS Measurement:
Qemu: 167779 KB
Proxy: 4019 KB
Shim: 8746 KB

Memory inside container:
Total Memory: 2043464 KB
Free Memory: 2003564 KB

opendev-zuul · 2018-09-03T02:11:42Z

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

kata-runsh : RETRY_LIMIT in 4m 33s

Fixes #671 To support kata-runtime update memory, need separate CPU/memory in agent grpc handler and handler query-memory-devices QMP commands in govmm. 1.Implement query-memory-devices QMP commands(govmm) 2.Add "CpuOnly" field to onlineCPUMem grpc request(agent) govmm Shortlog: b16291c qemu/qmp: support query-memory-devices qmp command. agent Shortlog: 74a5364 build: fix make proto error b1c2ad8 agent: add support for online memory and cpu separately. Signed-off-by: Zichang Lin <linzichang@huawei.com> Signed-off-by: Clare Chen <clare.chenhui@huawei.com>

katacontainersbot · 2018-09-03T02:30:56Z

PSS Measurement:
Qemu: 169621 KB
Proxy: 4131 KB
Shim: 8758 KB

Memory inside container:
Total Memory: 2043464 KB
Free Memory: 2003440 KB

linzichang · 2018-09-03T03:15:23Z

Don't merge, #624 need more agent.pb update.

opendev-zuul · 2018-09-03T03:28:24Z

Build succeeded (third-party-check pipeline).

kata-runsh : SUCCESS in 54m 52s

caoruidong · 2018-09-03T03:35:04Z

If so, I think this can be a commit of PR #624

jodh-intel · 2018-09-03T13:42:37Z

I agree with @caoruidong.

linzichang · 2018-09-06T12:19:05Z

Combine this into #624 . Close.

make sure the parent directory exists when opening the resolv.conf file. fixes: kata-containers#669 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

linzichang mentioned this pull request Aug 30, 2018

Update vendor to support memory update #671

Closed

devimc mentioned this pull request Aug 30, 2018

vendor: update govmm to be compatible with qemu 2.8 #649

Merged

WeiZhang555 added the duplicate Same issue as one already reported label Aug 31, 2018

caoruidong added do-not-merge and removed duplicate Same issue as one already reported labels Sep 3, 2018

linzichang closed this Sep 6, 2018

egernst pushed a commit to egernst/runtime that referenced this pull request Feb 9, 2021

network: ensure parent directories exist

7a7dba7

make sure the parent directory exists when opening the resolv.conf file. fixes: kata-containers#669 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Conversation

linzichang commented Aug 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linzichang commented Aug 30, 2018

Uh oh!

opendev-zuul bot commented Aug 30, 2018

Uh oh!

jodh-intel commented Aug 30, 2018 • edited by amshinde Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

opendev-zuul bot commented Aug 30, 2018

Uh oh!

opendev-zuul bot commented Aug 30, 2018

Uh oh!

katacontainersbot commented Aug 30, 2018

Uh oh!

devimc commented Aug 30, 2018

Uh oh!

codecov bot commented Aug 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

linzichang commented Aug 31, 2018

Uh oh!

caoruidong commented Aug 31, 2018

Uh oh!

WeiZhang555 commented Aug 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

katacontainersbot commented Aug 31, 2018

Uh oh!

linzichang commented Aug 31, 2018

Uh oh!

opendev-zuul bot commented Aug 31, 2018

Uh oh!

jshachm commented Aug 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jodh-intel commented Aug 31, 2018

Uh oh!

katacontainersbot commented Sep 3, 2018

Uh oh!

katacontainersbot commented Sep 3, 2018

Uh oh!

opendev-zuul bot commented Sep 3, 2018

Uh oh!

katacontainersbot commented Sep 3, 2018

Uh oh!

linzichang commented Sep 3, 2018

Uh oh!

opendev-zuul bot commented Sep 3, 2018

Uh oh!

caoruidong commented Sep 3, 2018

Uh oh!

jodh-intel commented Sep 3, 2018

Uh oh!

linzichang commented Sep 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

linzichang commented Aug 30, 2018 •

edited

Loading

jodh-intel commented Aug 30, 2018 •

edited by amshinde

Loading

codecov bot commented Aug 30, 2018 •

edited

Loading

WeiZhang555 commented Aug 31, 2018 •

edited

Loading

jshachm commented Aug 31, 2018 •

edited

Loading