Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

virtcontainers: Make qdisc of hotplug nics mq#651

Closed
caoruidong wants to merge 2 commits intokata-containers:masterfrom
caoruidong:mq-nic
Closed

virtcontainers: Make qdisc of hotplug nics mq#651
caoruidong wants to merge 2 commits intokata-containers:masterfrom
caoruidong:mq-nic

Conversation

@caoruidong
Copy link
Copy Markdown
Member

In order to avoid performance drop caused by qdisc. And align with
cold plug codes.

Fixes #650

@egernst egernst added the review label Aug 27, 2018
This update of govmm vendor will make qdisc of hotplug nics mq, which is align
with cold plug ones. And this will provide better performance.

Shortlog:
    0286ff9 qemu/qmp: support hotplug a nic whose qdisc is mq
    8515ae4 qmp: Remind users that you must first call ExecuteQMPCapabilities()

Signed-off-by: Ruidong Cao <caoruidong@huawei.com>
In order to avoid performance drop caused by qdisc. And align with
cold plug codes.

Fixes kata-containers#650

Signed-off-by: Ruidong Cao <caoruidong@huawei.com>
@WeiZhang555
Copy link
Copy Markdown
Member

WeiZhang555 commented Aug 27, 2018

Why not update govmm to latest 1a16b5f98f133796f9c5e9b6ae3aa6d786cff9b1 ?

I think this PR can merge with #649 , we don't need to update govmm twice in two different PR.

@katacontainersbot
Copy link
Copy Markdown
Contributor

PSS Measurement:
Qemu: 169406 KB
Proxy: 4092 KB
Shim: 8873 KB

Memory inside container:
Total Memory: 2043464 KB
Free Memory: 2002944 KB

@caoruidong
Copy link
Copy Markdown
Member Author

That will be fine. @woshijpf Will you take this change as part of your PR?

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@cc29b8d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #651   +/-   ##
=========================================
  Coverage          ?   65.35%           
=========================================
  Files             ?       85           
  Lines             ?     9880           
  Branches          ?        0           
=========================================
  Hits              ?     6457           
  Misses            ?     2766           
  Partials          ?      657

@opendev-zuul
Copy link
Copy Markdown

opendev-zuul bot commented Aug 27, 2018

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

Copy link
Copy Markdown

@devimc devimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flyflypeng
Copy link
Copy Markdown
Contributor

@caoruidong Ok,I will merge your change in kata-runtime into my PR #649

@caoruidong
Copy link
Copy Markdown
Member Author

@woshijpf Thanks. Close this.

@caoruidong caoruidong closed this Aug 27, 2018
@egernst egernst removed the review label Aug 27, 2018
flyflypeng added a commit to flyflypeng/runtime that referenced this pull request Aug 31, 2018
In order to avoid performance drop caused by qdisc. And align with
cold plug codes.

Fixes kata-containers#650

cherry-pick from: kata-containers#651

Signed-off-by: j00444339 <jiangpengfei9@huawei.com>
@caoruidong caoruidong deleted the mq-nic branch September 6, 2018 08:06
egernst pushed a commit to egernst/runtime that referenced this pull request Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants