This repository was archived by the owner on May 12, 2021. It is now read-only.
version: update nemu with latest virtiofs patches#1639
Closed
chavafg wants to merge 1 commit intokata-containers:masterfrom
Closed
version: update nemu with latest virtiofs patches#1639chavafg wants to merge 1 commit intokata-containers:masterfrom
chavafg wants to merge 1 commit intokata-containers:masterfrom
Conversation
chavafg
added a commit
to chavafg/tests-1
that referenced
this pull request
May 8, 2019
Add configuration option to use virtio-fs. We will currently use nemu for testing the virtio-fs support. Depends-on: github.com/kata-containers/runtime#1639 Fixes: kata-containers#1536. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
jodh-intel
reviewed
May 8, 2019
jodh-intel
left a comment
There was a problem hiding this comment.
Change looks fine but I think you'll need to update the uscan-url line above too to allow for the "pre-" prefix.
This nemu release includes the latest virtiofsd patches (changing the daemon message output). Fixes: kata-containers#1638. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
a5cb3cd to
b257135
Compare
Contributor
Author
|
Thanks @jodh-intel, updated the |
grahamwhaley
approved these changes
May 9, 2019
Contributor
grahamwhaley
left a comment
There was a problem hiding this comment.
lgtm
hmm, a 'pre' release - normally I'd say that is not something we want in our version files... but, in this case I trust we know what we are doing...
Contributor
|
/test |
Contributor
Author
|
closing in favor of #1645 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This nemu release includes the latest virtiofsd patches
(changing the daemon message output).
Fixes: #1638.
Signed-off-by: Salvador Fuentes salvador.fuentes@intel.com