This repository was archived by the owner on May 12, 2021. It is now read-only.
Merged
Conversation
Update to latest version of NEMU Fixes: kata-containers#1644 Signed-off-by: Eric Ernst <eric.ernst@intel.com>
Member
Author
|
/test |
ganeshmaharaj
approved these changes
May 9, 2019
People, these are VMMs, *not* hypervisors. Signed-off-by: Eric Ernst <eric.ernst@intel.com>
Member
Author
|
NEMU CI is the one that should be exercised here. |
grahamwhaley
approved these changes
May 9, 2019
Contributor
grahamwhaley
left a comment
There was a problem hiding this comment.
lgtm
ci seems happy.
we seem to have nearly overlapped this with #1639 - what gives?
Contributor
|
we know q35 ci is not happy right now - so, this is probably open to merge - am still interested in how we got two nemu bumps in a 10h window - maybe it was on purpose and planned, in which case maybe we needed to note that on the PRs? |
devimc
approved these changes
May 9, 2019
Contributor
|
@grahamwhaley not on purpose or planned to have both PRs, but this one is not a pre-release, so I can close my PR and merge this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.