disable yamux keep alive#71
Conversation
proxy.go
Outdated
| // 10 seconds is too early to suspect that a problem with the underlying connection has occurred. | ||
| // Since we don't know how much time a container can be paused let's set this timeout to 100 years, | ||
| // probably we won't be there when that occurs ;( | ||
| sessionConfig.ConnectionWriteTimeout = year * 100 |
There was a problem hiding this comment.
LOL !
@devimc is there any way to disable this timeout ? Something like providing 0 or -1 ?
There was a problem hiding this comment.
Why not disable keepalive directly? 100 years is amazing...
There was a problem hiding this comment.
hahahaha - dahh - good point, let me try xD
|
lgtm |
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 35.34% 35.89% +0.55%
==========================================
Files 2 2
Lines 232 234 +2
==========================================
+ Hits 82 84 +2
Misses 139 139
Partials 11 11
Continue to review full report at Codecov.
|
7f0c3de to
0abecce
Compare
|
changes applied, thanks :) |
|
let's wait a little for this PR kata-containers/tests#311 |
We don't know how much time a container can be paused, hence connection write timeout should be disabled to don't close the connection while the container is paused. fixes kata-containers/agent#231 fixes kata-containers#70 Signed-off-by: Julio Montes <julio.montes@intel.com>
0abecce to
8cd1037
Compare
|
kata-containers/tests#311 is green, we can merge it :) |
|
What's the benefit of keeping the proxy alive after a sandbox is paused? I think we can just kill the proxy process on pause and start it again when sandbox is resumed. |
|
@bergwolf good point, did you file an issue for that ? |
|
@bergwolf I am wondering if pausing the sandbox is really the thing to do here. Maybe we should not pause the VM and instead pause the container process directly inside the VM. |
Check that yamux connection write timeout never occurs. Connection write timeout occurs only if yamux default configuration is used to create the client. Depends-on: github.com/kata-containers/proxy#71 fixes clearcontainers#310 Signed-off-by: Julio Montes <julio.montes@intel.com>
We don't know how much time a container can be paused, hence connection
write timeout should be disabled to don't close the connection while
the container is paused.
fixes kata-containers/agent#231
fixes #70
Signed-off-by: Julio Montes julio.montes@intel.com