This repository was archived by the owner on Jun 28, 2024. It is now read-only.
integration/docker: add test to check yamux IO keep alive#311
Merged
chavafg merged 1 commit intokata-containers:masterfrom May 18, 2018
Merged
integration/docker: add test to check yamux IO keep alive#311chavafg merged 1 commit intokata-containers:masterfrom
chavafg merged 1 commit intokata-containers:masterfrom
Conversation
jcvenegas
reviewed
May 17, 2018
integration/docker/pause_test.go
Outdated
| Expect(0).To(Equal(exitCode)) | ||
| _, _, exitCode = dockerPause(id) | ||
| Expect(0).To(Equal(exitCode)) | ||
| time.Sleep(45 * time.Second) |
Member
There was a problem hiding this comment.
could you explain why 45 sec is needed and added it a comment if needed?
80a12f3 to
ec334e0
Compare
Author
|
@jcvenegas changes applied, thanks |
ec334e0 to
f77551f
Compare
jcvenegas
approved these changes
May 17, 2018
Member
|
@chavafg ptal. |
Author
|
waiting for kata-containers/proxy#71 |
Contributor
|
lgtm |
sboeuf
reviewed
May 17, 2018
sboeuf
left a comment
There was a problem hiding this comment.
You should mention in the commit message that this test is based on the default configuration. Otherwise the commit message is bit confusing.
Check that yamux connection write timeout never occurs. Connection write timeout occurs only if yamux default configuration is used to create the client. Depends-on: github.com/kata-containers/proxy#71 fixes kata-containers#310 Signed-off-by: Julio Montes <julio.montes@intel.com>
f77551f to
4c37c7a
Compare
Author
|
@sboeuf done, thanks |
sboeuf
approved these changes
May 17, 2018
jodh-intel
approved these changes
May 18, 2018
| }) | ||
| }) | ||
|
|
||
| // To get more info about this test, see https://github.com/kata-containers/agent/issues/231 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that yamux connection write timeout never occurs.
Connection write timeout occurs only if yamux default
configuration is used to create the client.
Depends-on: github.com/kata-containers/proxy#71
fixes #310
Signed-off-by: Julio Montes julio.montes@intel.com