Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

VM templating patch for QEMU 4.0#643

Closed
ganeshmaharaj wants to merge 1 commit intokata-containers:masterfrom
ganeshmaharaj:fix-vm-template
Closed

VM templating patch for QEMU 4.0#643
ganeshmaharaj wants to merge 1 commit intokata-containers:masterfrom
ganeshmaharaj:fix-vm-template

Conversation

@ganeshmaharaj
Copy link
Copy Markdown
Contributor

Since moving to QEMU 4.0 away from qemu-lite, we are missing the
migration patch
kata-containers/qemu@8ba3a0f
which helps with VM templating. Carrying the patch as part of kata
packaging while we wait for upstream to land the change.

Fixes: #642
Signed-off-by: Ganesh Maharaj Mahalingam ganesh.mahalingam@intel.com

@ganeshmaharaj
Copy link
Copy Markdown
Contributor Author

/test

ganeshmaharaj pushed a commit to ganeshmaharaj/kata-runtime that referenced this pull request Jul 17, 2019
Fixes: #123412345
Depends-on: github.com/kata-containers/packaging#643
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
Since moving to QEMU 4.0 away from qemu-lite, we are missing the
migration patch
kata-containers/qemu@8ba3a0f
which helps with VM templating. Carrying the patch as part of kata
packaging while we wait for upstream to land the change.

Fixes: kata-containers#642
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
@ganeshmaharaj
Copy link
Copy Markdown
Contributor Author

/test

@bergwolf bergwolf added the do-not-merge PR has problems or depends on another label Jul 18, 2019
@bergwolf
Copy link
Copy Markdown
Member

No, please don't bring it back. As I mentioned in #642 (comment), the problem is we merged packaging PR #641 before merging the dependent runtime PR kata-containers/runtime#1799.

@egernst
Copy link
Copy Markdown
Member

egernst commented Jul 18, 2019

Closing the PR. Thanks for the jump @ganeshmaharaj - glad to see we've adapted to upstream.

@egernst egernst closed this Jul 18, 2019
@ganeshmaharaj ganeshmaharaj deleted the fix-vm-template branch July 19, 2019 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

do-not-merge PR has problems or depends on another

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VM templating does not work on master

3 participants