This repository was archived by the owner on May 12, 2021. It is now read-only.
qemu: replace private migration patch with the upstream one#641
Merged
egernst merged 1 commit intokata-containers:masterfrom Jul 17, 2019
Merged
qemu: replace private migration patch with the upstream one#641egernst merged 1 commit intokata-containers:masterfrom
egernst merged 1 commit intokata-containers:masterfrom
Conversation
Then we can use x-ignore-shared to do migration and drop the extra patch once we move to qemu 4.1.0 or later. Fixes: kata-containers#640 Depends-on: github.com/kata-containers/runtime#1799 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
bergwolf
added a commit
to bergwolf/kata-runtime
that referenced
this pull request
Jul 17, 2019
qemu upstream has x-ignore-shared that works similar to our private bypass-shared-memory. We can use it to implement the vm template feature. Fixes: kata-containers#1798 Depends-on: github.com/kata-containers/packaging#641 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
Member
Author
|
/test |
bergwolf
added a commit
to bergwolf/kata-runtime
that referenced
this pull request
Jul 17, 2019
qemu upstream has x-ignore-shared that works similar to our private bypass-shared-memory. We can use it to implement the vm template feature. Fixes: kata-containers#1798 Depends-on: github.com/kata-containers/packaging#641 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
Member
Author
|
@chavafg How can I kick off ci here? Looks like |
jodh-intel
approved these changes
Jul 17, 2019
| - bool ignored = qemu_get_byte(f); | ||
| - if (ignored != ramblock_is_ignored(block)) { | ||
| - error_report("RAM block %s should %s be migrated", | ||
| - id, ignored ? "" : "not"); |
There was a problem hiding this comment.
Nit: this will cause an odd double space in the output when ignored is true so should really be:
error_report("RAM block %s should %sbe migrated",
id, ignored ? "" : "not ");
Member
Author
There was a problem hiding this comment.
@jodh-intel The patch is removing these lines not adding them ;)
grahamwhaley
approved these changes
Jul 17, 2019
Contributor
grahamwhaley
left a comment
There was a problem hiding this comment.
hah, diffs of patches - eye bending 👀
Looks like the CIs are running (at least pending builds) now..
bergwolf
added a commit
to bergwolf/kata-runtime
that referenced
this pull request
Jul 17, 2019
qemu upstream has x-ignore-shared that works similar to our private bypass-shared-memory. We can use it to implement the vm template feature. Fixes: kata-containers#1798 Depends-on: github.com/kata-containers/packaging#641 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
devimc
approved these changes
Jul 17, 2019
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 18, 2019
bergwolf
added a commit
to bergwolf/kata-runtime
that referenced
this pull request
Jul 18, 2019
qemu upstream has x-ignore-shared that works similar to our private bypass-shared-memory. We can use it to implement the vm template feature. Fixes: kata-containers#1798 Depends-on: github.com/kata-containers/packaging#641 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
egernst
pushed a commit
to egernst/runtime
that referenced
this pull request
Jul 18, 2019
qemu upstream has x-ignore-shared that works similar to our private bypass-shared-memory. We can use it to implement the vm template feature. Fixes: kata-containers#1798 Depends-on: github.com/kata-containers/packaging#641 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Then we can use x-ignore-shared to do migration and drop the
extra patch once we move to qemu 4.1.0 or later.
Fixes: #640
Depends-on: github.com/kata-containers/runtime#1799
Signed-off-by: Peng Tao bergwolf@hyper.sh