feat(client): add settings for gRPC client#479
Merged
Conversation
This was referenced Jun 14, 2023
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## lsa_manager #479 +/- ##
===============================================
- Coverage 62.35% 62.30% -0.05%
===============================================
Files 133 133
Lines 18446 18471 +25
===============================================
+ Hits 11502 11509 +7
- Misses 6371 6393 +22
+ Partials 573 569 -4
☔ View full report in Codecov by Sentry. |
Previously, the client provided WithGRPCDialOptions to configure general gRPC client options. However, it was challenging to use since there are so many options in gRPC, and hard for users to know the necessary things. This PR provides more specific options: - WithGRPCReadBufferSize - WithGRPCWriteBufferSize - WithGRPCInitialConnWindowSize - WithGRPCInitialWindowSize It also sets up some options like MaxCallRecvMsgSize and MaxCallSendMsgSize. It uses math.MaxInt32 value for them. Varlog users are not necessarily taken into account the maximum message size limit.
a73c054 to
917e5fc
Compare
hungryjang
approved these changes
Jun 19, 2023
Member
Author
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Previously, the client provided WithGRPCDialOptions to configure general gRPC client options. However, it was challenging to use since there are so many options in gRPC, and hard for users to know the necessary things.
This PR provides more specific options:
It also sets up some options like MaxCallRecvMsgSize and MaxCallSendMsgSize. It uses math.MaxInt32 value for them. Varlog users are not necessarily taken into account the maximum message size limit.