feat(client): support goroutine-safety of pkg/var log.(LogStream Appender).Append Batch#472
Merged
feat(client): support goroutine-safety of pkg/var log.(LogStream Appender).Append Batch#472
Conversation
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Jun 12, 2023
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
- Coverage 62.71% 62.58% -0.14%
==========================================
Files 133 133
Lines 18336 18358 +22
==========================================
- Hits 11500 11489 -11
- Misses 6263 6295 +32
- Partials 573 574 +1
☔ View full report in Codecov by Sentry. |
…nder).Append Batch This PR makes `kg/var log.(LogStream Appender).Append Batch` goroutine-safe.
8765e09 to
7fa53f3
Compare
hungryjang
approved these changes
Jun 16, 2023
Member
Author
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR makes
kg/var log.(LogStream Appender).Append Batchgoroutine-safe.