Skip to content

Docs: Add note about JwtParserBuilder creating an immutable JwtParser#508

Merged
bdemers merged 1 commit intoREADME-0-11-0from
issue-171-take2
Oct 3, 2019
Merged

Docs: Add note about JwtParserBuilder creating an immutable JwtParser#508
bdemers merged 1 commit intoREADME-0-11-0from
issue-171-take2

Conversation

@bdemers
Copy link
Member

@bdemers bdemers commented Oct 1, 2019

Fixes: #171

@coveralls
Copy link

coveralls commented Oct 1, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling d63620e on issue-171-take2 into 7adb872 on README-0-11-0.

Copy link
Contributor

@lhazlewood lhazlewood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

* Returns a {@link JwtParser} created from the configuration from this JwtParserBuilder.
* @return a JwtParser created from the configuration from this JwtParserBuilder.
* Returns a immutable/thread-safe {@link JwtParser} created from the configuration from this JwtParserBuilder.
* @return a immutable/thread-safe JwtParser created from the configuration from this JwtParserBuilder.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically an immutable/thread-safe..., but I'll still approve 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, i'll fix that before merging

@bdemers bdemers force-pushed the issue-171-take2 branch 2 times, most recently from 302ef3b to 0e0fcb4 Compare October 3, 2019 18:14
@bdemers bdemers merged commit 41aa455 into README-0-11-0 Oct 3, 2019
@bdemers bdemers deleted the issue-171-take2 branch October 3, 2019 21:43
lhazlewood pushed a commit that referenced this pull request Feb 4, 2020
- Docs: Adds section to README covering custom object parsing (#500)
- Docs: Add note about JwtParserBuilder creating an immutable JwtParser (#508)
Doc: #486
Fixes: #494
Doc: #495
Fixes: #171
lhazlewood pushed a commit that referenced this pull request Feb 5, 2020
- Docs: Adds section to README covering custom object parsing (#500)
- Docs: Add note about JwtParserBuilder creating an immutable JwtParser (#508)
Doc: #486
Fixes: #494
Doc: #495
Fixes: #171

Updated documentation and changelog to reflect the new Gson extension. Fixes #410. (#476)
lhazlewood added a commit that referenced this pull request Feb 5, 2020
…#559)

- Docs: Adds section to README covering custom object parsing (#500)
- Docs: Add note about JwtParserBuilder creating an immutable JwtParser (#508)
Doc: #486
Fixes: #494
Doc: #495
Fixes: #171

Updated documentation and changelog to reflect the new Gson extension. Fixes #410. (#476)

Co-authored-by: Brian Demers <brian.demers@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants