Skip to content

feat(router): add organization_id in authentication table and add it in authentication events#7168

Merged
likhinbopanna merged 5 commits intomainfrom
add-organization-id-in-authentication-table-clickhouse
Feb 6, 2025
Merged

feat(router): add organization_id in authentication table and add it in authentication events#7168
likhinbopanna merged 5 commits intomainfrom
add-organization-id-in-authentication-table-clickhouse

Conversation

@sai-harsha-vardhan
Copy link
Contributor

@sai-harsha-vardhan sai-harsha-vardhan commented Feb 3, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  1. add organization_id in authentication table of postgres
  2. add organization_id in kafka queue and authentications table of clickhouse
  3. send organization_id while logging events to clickhouse

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually
Perform Sanity External 3DS payment to check organization_id being stored in authentication table
CURL

curl --location 'localhost:8080/payments/pay_EXpcC46YuZUwLX8DrXlA/3ds/authentication' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: pk_dev_74ab7c8aac7c49d793f9c980c544a09f' \
--data '{
    "client_secret": "pay_EXpcC46YuZUwLX8DrXlA_secret_AcTKJleY3B1DFVdS3hlU",
    "device_channel": "BRW",
    "threeds_method_comp_ind": "Y"
}'

Database
image

Kafka Queue
image

Clickhouse table
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-feature Category: Feature request or enhancement labels Feb 3, 2025
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Feb 3, 2025
@sai-harsha-vardhan sai-harsha-vardhan requested review from a team as code owners February 3, 2025 09:43
@semanticdiff-com
Copy link

semanticdiff-com bot commented Feb 3, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/analytics/docs/clickhouse/scripts/authentications.sql Unsupported file format
  crates/diesel_models/src/authentication.rs  0% smaller
  crates/diesel_models/src/schema.rs  0% smaller
  crates/diesel_models/src/schema_v2.rs  0% smaller
  crates/router/src/core/authentication.rs  0% smaller
  crates/router/src/core/authentication/utils.rs Unsupported file format
  crates/router/src/core/payments/operations/payment_confirm.rs  0% smaller
  crates/router/src/core/unified_authentication_service.rs  0% smaller
  crates/router/src/db/authentication.rs  0% smaller
  crates/router/src/services/kafka/authentication.rs  0% smaller
  crates/router/src/services/kafka/authentication_event.rs  0% smaller
  migrations/2025-01-30-111507_add_organization_id_in_authentication/down.sql Unsupported file format
  migrations/2025-01-30-111507_add_organization_id_in_authentication/up.sql Unsupported file format

@sai-harsha-vardhan sai-harsha-vardhan requested a review from a team as a code owner February 3, 2025 09:54
@sai-harsha-vardhan sai-harsha-vardhan added the M-database-changes Metadata: This PR involves database schema changes label Feb 3, 2025
Narayanbhat166
Narayanbhat166 previously approved these changes Feb 5, 2025
View reviewed changes
tsdk02
tsdk02 reviewed Feb 5, 2025
View reviewed changes
@likhinbopanna likhinbopanna added this pull request to the merge queue Feb 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2025
@likhinbopanna likhinbopanna added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit f211754 Feb 6, 2025
17 of 20 checks passed
@likhinbopanna likhinbopanna deleted the add-organization-id-in-authentication-table-clickhouse branch February 6, 2025 15:19
pixincreate added a commit that referenced this pull request Feb 7, 2025
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into ci/make-amo…
b6b3dfe 
…unt-configurable

* 'main' of github.com:juspay/hyperswitch: (37 commits)
  refactor(router): add display_name field to connector feature api  (#7121)
  ci(cypress): Add Tests for Customer Deletion and Psync flows (#7158)
  feat(connector): [DataTrans] ADD 3DS Flow (#6026)
  chore(version): 2025.02.07.0
  chore(connectors): [fiuu] update pm_filters for apple pay and google pay (#7182)
  feat(router): add `organization_id` in authentication table and add it in authentication events (#7168)
  fix(dashboard_metadata): mask `poc_email` and `data_value` for DashboardMetadata (#7130)
  feat(core): Add support for v2 payments get intent using merchant reference id (#7123)
  refactor(customer): return redacted customer instead of error (#7122)
  fix(connector): handle unexpected error response from bluesnap connector (#7120)
  feat(routing): Contract based routing integration  (#6761)
  refactor(dynamic_fields): dynamic fields for Adyen and Stripe, renaming klarnaCheckout, WASM for KlarnaCheckout (#7015)
  feat(connector): [COINGATE] Add Template PR  (#7052)
  chore(roles): remove redundant variant from PermissionGroup (#6985)
  refactor(router): store `network_transaction_id` for `off_session` payments irrespective of the `is_connector_agnostic_mit_enabled` config (#7083)
  chore(connector): [Fiuu] log keys in the PSync response (#7189)
  ci(cypress): fix nmi and paypal (#7173)
  chore(version): 2025.02.06.0
  chore(postman): update Postman collection files
  feat(connector): [Deutschebank] Add Access Token Error struct (#7127)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsdk02 tsdk02 tsdk02 approved these changes

+2 more reviewers

@Chethan-rao Chethan-rao Chethan-rao approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels

A-core Area: Core flows C-feature Category: Feature request or enhancement M-database-changes Metadata: This PR involves database schema changes

Projects

None yet

Milestone

February 2025 Release

Development

Successfully merging this pull request may close these issues.

5 participants

@sai-harsha-vardhan @Narayanbhat166 @Chethan-rao @tsdk02 @likhinbopanna