chore(roles): remove redundant variant from PermissionGroup#6985
Merged
likhinbopanna merged 5 commits intomainfrom Feb 6, 2025
Merged
Conversation
2 tasks
|
Review changes with Changed Files
|
ThisIsMani
reviewed
Jan 16, 2025
| @@ -0,0 +1 @@ | |||
| SELECT 1; | |||
Contributor
There was a problem hiding this comment.
Should we replace the groups back here? If someone rolls back to older version, new variant wouldn't work.
Contributor
Author
There was a problem hiding this comment.
We cannot revert the groups back, this is a one time activity for renaming recon_ops to recon_ops_manage. Once this is done, we will lose context of which groups were recon_ops, and that's expected since application expects recon_ops_manage
If someone rolls back to an older version of the application, it will work regardless since we've had the new variant (ReconOpsManage) for a while.
Contributor
There was a problem hiding this comment.
But I don't see any issue in replacing either... If someone reverts to the version where ReconOpsManage is not present, then it wouldn't work without replacing.
I would not expect anyone to do so. But, this is something I can think of which will give us advantage without any downsides...
ThisIsMani
approved these changes
Jan 22, 2025
jarnura
approved these changes
Jan 23, 2025
pixincreate
added a commit
that referenced
this pull request
Feb 7, 2025
…unt-configurable * 'main' of github.com:juspay/hyperswitch: (37 commits) refactor(router): add display_name field to connector feature api (#7121) ci(cypress): Add Tests for Customer Deletion and Psync flows (#7158) feat(connector): [DataTrans] ADD 3DS Flow (#6026) chore(version): 2025.02.07.0 chore(connectors): [fiuu] update pm_filters for apple pay and google pay (#7182) feat(router): add `organization_id` in authentication table and add it in authentication events (#7168) fix(dashboard_metadata): mask `poc_email` and `data_value` for DashboardMetadata (#7130) feat(core): Add support for v2 payments get intent using merchant reference id (#7123) refactor(customer): return redacted customer instead of error (#7122) fix(connector): handle unexpected error response from bluesnap connector (#7120) feat(routing): Contract based routing integration (#6761) refactor(dynamic_fields): dynamic fields for Adyen and Stripe, renaming klarnaCheckout, WASM for KlarnaCheckout (#7015) feat(connector): [COINGATE] Add Template PR (#7052) chore(roles): remove redundant variant from PermissionGroup (#6985) refactor(router): store `network_transaction_id` for `off_session` payments irrespective of the `is_connector_agnostic_mit_enabled` config (#7083) chore(connector): [Fiuu] log keys in the PSync response (#7189) ci(cypress): fix nmi and paypal (#7173) chore(version): 2025.02.06.0 chore(postman): update Postman collection files feat(connector): [Deutschebank] Add Access Token Error struct (#7127) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This removes the redundant
ReconOpsvariant fromPermissionGroupenum which is stored in DB. This was kept back in application for backwards compatibility. Migrations are added for this and this will not be needed anymore.Additional Changes
Motivation and Context
Helps in keeping a clean permission view on HS dashboard.
How did you test it?
Locally by running migrations and viewing permission view in dashboard.
Checklist
cargo +nightly fmt --allcargo clippy