Handle and clear kwargs to Dir#[] and glob#9284
Closed
headius wants to merge 1 commit intojruby:jruby-10.0from
Closed
Handle and clear kwargs to Dir#[] and glob#9284headius wants to merge 1 commit intojruby:jruby-10.0from
headius wants to merge 1 commit intojruby:jruby-10.0from
Conversation
f095a25 to
3cbba73
Compare
kares
reviewed
Mar 3, 2026
| // returns null (no kwargs present), "" kwargs but no base key, "something" kwargs with base key (which might be ""). | ||
| private static void globOptions(ThreadContext context, IRubyObject[] args, String[] keys, GlobOptions options) { | ||
| Ruby runtime = context.runtime; | ||
| int callInfo = ThreadContext.resetCallInfo(context); |
Member
There was a problem hiding this comment.
Dir.glob was really just a demonstration of the issue,
there's still a bunch of ThreadContext.resetCallInfo in other places.
should those be reviewed as well?
Member
Author
There was a problem hiding this comment.
@kares Case-by-case basic I suppose. Any place that declares it takes kwargs but doesn't reset callInfo is broken.
headius
added a commit
to headius/jruby
that referenced
this pull request
Mar 3, 2026
This is the trivial fix for jruby#9281. A separate PR in jruby#9284 did not correctly untangle the kwarg handling logic, so we're pushing it to a future release. Fixes jruby#9281
Member
Author
|
This is still broken and needs a deeper investigation. We'll go with #9285 for 10.0.4.0 and fix this "the right way" for a future release. |
Member
|
full call-info review is now at: #9302 |
Member
Author
|
Superseded by #9302. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9281