Merged
Conversation
Member
kwargs could still be kept -> polluting next call-site
enebo
reviewed
Mar 16, 2026
| isLambda = (callInfo & ThreadContext.CALL_KEYWORD) != 0 ? | ||
| lambdaOpt.isTrue() : | ||
| isLambda(); | ||
| isLambda = hasKeywords(callInfo) ? lambdaOpt.isTrue() : isLambda(); |
Member
There was a problem hiding this comment.
This could be simplified to:
var isLambda = !lambdaOpt.isNice` && hasKeywords(callInfo) ?
lambdaOpt.isTrue() :
isLambda();
Member
There was a problem hiding this comment.
I realize this is merged. Just noticed the logic could be simplified.
Member
|
As a comment for posterity. I think passing callInfo as a value in the two places which introduced the extra passing is baking callInfo into the API which was not a goal of callInfo (it was meant to be a temporary workaround for not changing all call code paths). That said, those two places are private and can be backed out simply when a longer term solution comes along. So I was ok with this PR but just thought it is worth mentioning somewhere that the goal was to minimally affect API call paths with callInfo as a value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trying to get the
keywords = truealigned with properresetCallInfo, where it's needed (follow-up on #9285).on some places this won't trigger an issue unless something changes in the method (would be easy to miss).
but there also are places where
ArgumentErrorreproduces easily (similar to #9281) e.g.the above isn't completely fixed due being quite specific and reveals an issue with:IRRuntimeHelper.setCallInfowhich retains the empty flagthink that should only be used in specific circumstances as the retaining causes issues (such as above).not 100% why it's kept (esp. the JIT parts) yet and whether simply changing tofor now this is not needed, the above bug was resolved.context.callInfo = flagswould not cause more harm