Skip to content

Conversation

@mgol
Copy link
Member

@mgol mgol commented Aug 4, 2025

Summary

This is a 3.x version of gh-5682.

The -j switch passed to tar indicates the archive is compressed using the bzip2 format (bz2 extension). That was how Firefox used to be compressed until recently, but the new ESR release now uses xz. Ubuntu tar doesn't auto-guess the encryption algorithm, so to support both, first try with xz and fall back to bzip2 if that fails.

Note: this will download the old Firefox ESR twice, but it will still work when the current ESR version starts to use xz with no changes to the code

Ref gh-5682

Checklist

@mgol mgol added this to the 3.8.0 milestone Aug 4, 2025
@mgol mgol requested a review from timmywil August 4, 2025 16:59
@mgol mgol self-assigned this Aug 4, 2025
The `-j` switch passed to `tar` indicates the archive is compressed using the
bzip2 format (`bz2` extension). That was how Firefox used to be compressed until
recently, but the new ESR release now uses xz. Ubuntu `tar` doesn't auto-guess
the encryption algorithm, so to support both, first try with xz and fall back
to bzip2 if that fails.

Note: this will download the old Firefox ESR twice, but it will still work
when the current ESR version starts to use xz with no changes to the code.

Ref jquerygh-5682
@mgol mgol force-pushed the 3.x-firefox-esr-fix branch from 13a4c40 to 475461c Compare August 4, 2025 17:00
mgol added a commit to mgol/jquery that referenced this pull request Aug 4, 2025
The `-j` switch passed to `tar` indicates the archive is compressed using the
bzip2 format (`bz2` extension). That was how Firefox used to be compressed until
recently, but the new ESR release now uses xz. Ubuntu `tar` doesn't auto-guess
the encryption algorithm, so to support both, first try with xz and fall back
to bzip2 if that fails.

Note: this will download the old Firefox ESR twice, but it will still work
when the current ESR version starts to use xz with no changes to the code.

Ref jquerygh-5684
@mgol mgol changed the title Build: Try to unpack Firefox ESR via xz, fall back to bzip2 Build: Try to unpack Firefox ESR via xz, fall back to bzip2 (3.x) Aug 4, 2025
@mgol mgol removed the Needs review label Aug 4, 2025
mgol added a commit that referenced this pull request Aug 4, 2025
The `-j` switch passed to `tar` indicates the archive is compressed using the
bzip2 format (`bz2` extension). That was how Firefox used to be compressed until
recently, but the new ESR release now uses xz. Ubuntu `tar` doesn't auto-guess
the encryption algorithm, so to support both, first try with xz and fall back
to bzip2 if that fails.

Note: this will download the old Firefox ESR twice, but it will still work
when the current ESR version starts to use xz with no changes to the code.

Closes gh-5682
Ref gh-5684
@mgol mgol merged commit d298376 into jquery:3.x-stable Aug 4, 2025
30 of 31 checks passed
@mgol mgol deleted the 3.x-firefox-esr-fix branch August 4, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants