Skip to content

Conversation

@mgol
Copy link
Member

@mgol mgol commented Aug 4, 2025

Summary

The -j switch passed to tar indicates the archive is compressed using the
bzip2 format (bz2 extension). That was how Firefox used to be compressed until
recently, but the new ESR release now uses xz. Ubuntu tar doesn't auto-guess
the encryption algorithm, so to support both, first try with xz and fall back
to bzip2 if that fails.

Note: this will download the old Firefox ESR twice, but it will still work
when the current ESR version starts to use xz with no changes to the code.

3.x version: #5684

Checklist

@mgol mgol added this to the 4.0.0 milestone Aug 4, 2025
@mgol mgol self-assigned this Aug 4, 2025
@mgol mgol force-pushed the firefox-esr-fix branch from 509be9f to a3501e2 Compare August 4, 2025 16:22
@mgol mgol force-pushed the firefox-esr-fix branch from a3501e2 to 47bc5a2 Compare August 4, 2025 16:52
@mgol mgol requested a review from timmywil August 4, 2025 16:56
@mgol mgol changed the title Build: Don't specify the bz2 algorithm in the tar extraction command Build: Try to unpack Firefox ESR via xz, fall back to bzip2 Aug 4, 2025
mgol added a commit to mgol/jquery that referenced this pull request Aug 4, 2025
The `-j` switch passed to `tar` indicates the archive is compressed using the
bzip2 format (`bz2` extension). That was how Firefox used to be compressed until
recently, but the new ESR release now uses xz. Ubuntu `tar` doesn't auto-guess
the encryption algorithm, so to support both, first try with xz and fall back
to bzip2 if that fails.

Note: this will download the old Firefox ESR twice, but it will still work
when the current ESR version starts to use xz with no changes to the code

Ref jquerygh-5682
mgol added a commit to mgol/jquery that referenced this pull request Aug 4, 2025
The `-j` switch passed to `tar` indicates the archive is compressed using the
bzip2 format (`bz2` extension). That was how Firefox used to be compressed until
recently, but the new ESR release now uses xz. Ubuntu `tar` doesn't auto-guess
the encryption algorithm, so to support both, first try with xz and fall back
to bzip2 if that fails.

Note: this will download the old Firefox ESR twice, but it will still work
when the current ESR version starts to use xz with no changes to the code.

Ref jquerygh-5682
The `-j` switch passed to `tar` indicates the archive is compressed using the
bzip2 format (`bz2` extension). That was how Firefox used to be compressed until
recently, but the new ESR release now uses xz. Ubuntu `tar` doesn't auto-guess
the encryption algorithm, so to support both, first try with xz and fall back
to bzip2 if that fails.

Note: this will download the old Firefox ESR twice, but it will still work
when the current ESR version starts to use xz with no changes to the code.

Ref jquerygh-5684
@mgol mgol removed the Needs review label Aug 4, 2025
@mgol mgol merged commit dc5d1f7 into jquery:main Aug 4, 2025
42 of 45 checks passed
@mgol mgol deleted the firefox-esr-fix branch August 4, 2025 21:48
mgol added a commit that referenced this pull request Aug 4, 2025
The `-j` switch passed to `tar` indicates the archive is compressed using the
bzip2 format (`bz2` extension). That was how Firefox used to be compressed until
recently, but the new ESR release now uses xz. Ubuntu `tar` doesn't auto-guess
the encryption algorithm, so to support both, first try with xz and fall back
to bzip2 if that fails.

Note: this will download the old Firefox ESR twice, but it will still work
when the current ESR version starts to use xz with no changes to the code.

Closes gh-5684
Ref gh-5682
mgol added a commit to mgol/jquery-migrate that referenced this pull request Sep 12, 2025
The previous config declared Firefox ESR testing, but the tests were never run
due to clashing names with main Firefox test runs. Apart from fixing that,
backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded
despite using different compression algorithms.

Ref jquery/jquery#5682
mgol added a commit to mgol/jquery-migrate that referenced this pull request Sep 12, 2025
The previous config declared Firefox ESR testing, but the tests were never run
due to clashing names with main Firefox test runs. Apart from fixing that,
backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded
despite using different compression algorithms.

Ref jquery/jquery#5682
mgol added a commit to mgol/jquery-migrate that referenced this pull request Sep 12, 2025
The previous config declared Firefox ESR testing, but the tests were never run
due to clashing names with main Firefox test runs. Apart from fixing that,
backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded
despite using different compression algorithms.

Ref jquery/jquery#5682
mgol added a commit to mgol/jquery-migrate that referenced this pull request Sep 12, 2025
The previous config declared Firefox ESR testing, but the tests were never run
due to clashing names with main Firefox test runs. Apart from fixing that,
backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded
despite using different compression algorithms.

Ref jquerygh-597
Ref jquery/jquery#5682
mgol added a commit to mgol/jquery-migrate that referenced this pull request Sep 12, 2025
The previous config declared Firefox ESR testing, but the tests were never run
due to clashing names with main Firefox test runs. Apart from fixing that,
backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded
despite using different compression algorithms.

Ref jquerygh-598
Ref jquery/jquery#5682
mgol added a commit to jquery/jquery-migrate that referenced this pull request Sep 12, 2025
The previous config declared Firefox ESR testing, but the tests were never
run due to clashing names with main Firefox test runs. Apart from fixing
that, backport jquery/jquery#5682 so that both Firefox ESR versions can be
downloaded despite using different compression algorithms.

Also, Simplify caching in CI: our setup is pretty standard, so manual
configuration of `actions/cache` is an overkill. Relying on built-in
`actions/node` caching will also resolve differences between caching
configurations for macOS/Linux vs. Windows.

Closes gh-597
Ref gh-598
Ref jquery/jquery#5682
mgol added a commit to jquery/jquery-migrate that referenced this pull request Sep 15, 2025
The previous config declared Firefox ESR testing, but the tests were never
run due to clashing names with main Firefox test runs. Apart from fixing
that, backport jquery/jquery#5682 so that both Firefox ESR versions can be
downloaded despite using different compression algorithms.

Also, Simplify caching in CI: our setup is pretty standard, so manual
configuration of `actions/cache` is an overkill. Relying on built-in
`actions/node` caching will also resolve differences between caching
configurations for macOS/Linux vs. Windows.

Closes gh-598
Ref gh-597
Ref jquery/jquery#5682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants