-
Notifications
You must be signed in to change notification settings - Fork 20.5k
Build: Try to unpack Firefox ESR via xz, fall back to bzip2 #5682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Aug 4, 2025
The `-j` switch passed to `tar` indicates the archive is compressed using the bzip2 format (`bz2` extension). That was how Firefox used to be compressed until recently, but the new ESR release now uses xz. Ubuntu `tar` doesn't auto-guess the encryption algorithm, so to support both, first try with xz and fall back to bzip2 if that fails. Note: this will download the old Firefox ESR twice, but it will still work when the current ESR version starts to use xz with no changes to the code Ref jquerygh-5682
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Aug 4, 2025
The `-j` switch passed to `tar` indicates the archive is compressed using the bzip2 format (`bz2` extension). That was how Firefox used to be compressed until recently, but the new ESR release now uses xz. Ubuntu `tar` doesn't auto-guess the encryption algorithm, so to support both, first try with xz and fall back to bzip2 if that fails. Note: this will download the old Firefox ESR twice, but it will still work when the current ESR version starts to use xz with no changes to the code. Ref jquerygh-5682
The `-j` switch passed to `tar` indicates the archive is compressed using the bzip2 format (`bz2` extension). That was how Firefox used to be compressed until recently, but the new ESR release now uses xz. Ubuntu `tar` doesn't auto-guess the encryption algorithm, so to support both, first try with xz and fall back to bzip2 if that fails. Note: this will download the old Firefox ESR twice, but it will still work when the current ESR version starts to use xz with no changes to the code. Ref jquerygh-5684
2 tasks
timmywil
approved these changes
Aug 4, 2025
mgol
added a commit
that referenced
this pull request
Aug 4, 2025
The `-j` switch passed to `tar` indicates the archive is compressed using the bzip2 format (`bz2` extension). That was how Firefox used to be compressed until recently, but the new ESR release now uses xz. Ubuntu `tar` doesn't auto-guess the encryption algorithm, so to support both, first try with xz and fall back to bzip2 if that fails. Note: this will download the old Firefox ESR twice, but it will still work when the current ESR version starts to use xz with no changes to the code. Closes gh-5684 Ref gh-5682
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
Sep 12, 2025
The previous config declared Firefox ESR testing, but the tests were never run due to clashing names with main Firefox test runs. Apart from fixing that, backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded despite using different compression algorithms. Ref jquery/jquery#5682
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
Sep 12, 2025
The previous config declared Firefox ESR testing, but the tests were never run due to clashing names with main Firefox test runs. Apart from fixing that, backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded despite using different compression algorithms. Ref jquery/jquery#5682
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
Sep 12, 2025
The previous config declared Firefox ESR testing, but the tests were never run due to clashing names with main Firefox test runs. Apart from fixing that, backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded despite using different compression algorithms. Ref jquery/jquery#5682
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
Sep 12, 2025
The previous config declared Firefox ESR testing, but the tests were never run due to clashing names with main Firefox test runs. Apart from fixing that, backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded despite using different compression algorithms. Ref jquerygh-597 Ref jquery/jquery#5682
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
Sep 12, 2025
The previous config declared Firefox ESR testing, but the tests were never run due to clashing names with main Firefox test runs. Apart from fixing that, backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded despite using different compression algorithms. Ref jquerygh-598 Ref jquery/jquery#5682
mgol
added a commit
to jquery/jquery-migrate
that referenced
this pull request
Sep 12, 2025
The previous config declared Firefox ESR testing, but the tests were never run due to clashing names with main Firefox test runs. Apart from fixing that, backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded despite using different compression algorithms. Also, Simplify caching in CI: our setup is pretty standard, so manual configuration of `actions/cache` is an overkill. Relying on built-in `actions/node` caching will also resolve differences between caching configurations for macOS/Linux vs. Windows. Closes gh-597 Ref gh-598 Ref jquery/jquery#5682
mgol
added a commit
to jquery/jquery-migrate
that referenced
this pull request
Sep 15, 2025
The previous config declared Firefox ESR testing, but the tests were never run due to clashing names with main Firefox test runs. Apart from fixing that, backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded despite using different compression algorithms. Also, Simplify caching in CI: our setup is pretty standard, so manual configuration of `actions/cache` is an overkill. Relying on built-in `actions/node` caching will also resolve differences between caching configurations for macOS/Linux vs. Windows. Closes gh-598 Ref gh-597 Ref jquery/jquery#5682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
-jswitch passed totarindicates the archive is compressed using thebzip2 format (
bz2extension). That was how Firefox used to be compressed untilrecently, but the new ESR release now uses xz. Ubuntu
tardoesn't auto-guessthe encryption algorithm, so to support both, first try with xz and fall back
to bzip2 if that fails.
Note: this will download the old Firefox ESR twice, but it will still work
when the current ESR version starts to use xz with no changes to the code.
3.x version: #5684
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com