Effects: Remove additional parameters of easings#2376
Closed
mr21 wants to merge 2 commits into
Closed
Conversation
Member
There was a problem hiding this comment.
The last percent should have its own line.
Member
|
I like it! |
Member
|
Could we try to land #2326 first and then you can update the test I wrote in there as well? |
Contributor
Author
|
After you ;) |
Contributor
Author
|
@gnarf, it's merged :) |
Member
There was a problem hiding this comment.
can you update the comment here the "back-compat" arguments you removed :)
Contributor
Author
There was a problem hiding this comment.
Done:
ok( easingSpy.calledWith( 0.1 ), "...using jQuery.easing.linear" );
Member
|
Can we make an issue on the jQuery migrate plugin to add a shim to put the additional easing params back? |
Member
|
LGTM |
Member
|
Thanks, landed. |
Closed
Closed
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi :)
A fix for #2367