Effects: Add tests for jQuery.Tween#2326
Conversation
There was a problem hiding this comment.
We've settled on nodeType as the DOM node discriminator... I'd say that means replacing !tween.elem.style with tween.elem.nodeType !== 1 here, and tween.elem.style with tween.elem.nodeType === 1 in set. There's also some rearranging to make them more compressible, but that can come after the logic update.
|
Thanks @arschmitz for the spaces nits, super useful. I'm thinking about splitting this into its own test file so I can turn on the jscs. |
There was a problem hiding this comment.
+cc @jquery/core What is the max line length?
There was a problem hiding this comment.
Do not change jscsrc, it was already defined correctly - http://contribute.jquery.org/style-guide/js/#spacing
Lines should be no longer than 80 characters, and must not exceed 100 (counting tabs as 4 spaces). There are 2 exceptions, both allowing the line to exceed 100 characters:
There was a problem hiding this comment.
100, search the string "Lines should be" here https://contribute.jquery.org/style-guide/js/ :)
oh crap, I didn't refresh my page.
There was a problem hiding this comment.
I tried searching the style guide for it, but my find fu was poor I suppose...
So if it was "defined correctly" why wasn't it erroring on my long lines?
There was a problem hiding this comment.
Reverted this change, found that the new version of jscs works - but grunt doesn't run it...
😦 -- such a pain to follow our style guide right now when the tooling isn't up to date.
bb1cb30 to
a0679da
Compare
Covers
$.Animationand$.Tweenhook/extension points.See #2340 for the compat branch version