Feat: Enhance Kronecker product to handle arbitrary dimension#3461
Merged
gwhitney merged 5 commits intojosdejong:v15from Apr 23, 2025
Merged
Feat: Enhance Kronecker product to handle arbitrary dimension#3461gwhitney merged 5 commits intojosdejong:v15from
gwhitney merged 5 commits intojosdejong:v15from
Conversation
* Corrects doc example * Factors out 1-dimensional Kronecker product * Reimplement Kronecker product recursively to support arbitrary dimension * Adds further tests, including up to 3D Kronecker products
gwhitney
added a commit
that referenced
this pull request
Jul 3, 2025
Previously `math.kron()` always returned a 2D matrix, and could not handle 3D or greater arrays. Now it always returns an array of the max dimension of its arguments. Resolves #1753. --------- Co-authored-by: Delaney Sylvans <delaneysylvans@gmail.com>
Owner
|
Published now in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1753.
This is an identical copy of #3455 (thanks @Delaney) but rebased onto v15, created so as to avoid force-pushing to a contributor's fork.