Enhance Kronecker product to handle arbitrary dimension#3455
Enhance Kronecker product to handle arbitrary dimension#3455Delaney wants to merge 5 commits intojosdejong:v15from
Conversation
* Corrects doc example * Factors out 1-dimensional Kronecker product * Reimplement Kronecker product recursively to support arbitrary dimension * Adds further tests, including up to 3D Kronecker products
|
Thanks! Yours was the first correct implementation for the 1d Kronecker product, and it showed how the 1D product could be factored out of the 2D product, which in turn made it clear how to support arbitrary dimension of the arguments (recursively). I've now added a commit that implements all that, and corrected the doc test for kron which was failing (you should do Except for needing a HISTORY line (reviewer's responsibility, not yours), this is good to go -- except unfortunately it is a breaking change (alters |
|
OK, I had to rebase on v15 to get the HISTORY straight, and since I didn't know if you would want me to force-push to your fork, I created the replacement copy #3461 of this, which I am closing this in favor of. Thanks for the contribution! |
|
Thanks @Delaney! |
Fixes #1753