Correct warning "A non-numeric value encountered" in utf8.php#22
Merged
mbabker merged 1 commit intojoomla-framework:masterfrom Jun 16, 2019
Merged
Conversation
Contributor
Author
|
Does it need to do the same for the 2.0-dev branch in another PR, or will that change be merged to that branch as soon as merged into master? |
Contributor
|
All changes in 1.x merge forward to newer version branches, so only one PR
is required.
If a PR per branch were required, the software would in effect fork itself.
On Sun, Jun 16, 2019 at 9:19 AM Richard Fath ***@***.***> wrote:
Does it need to do the same for the 2.0-dev branch in another PR, or will
that change be merged to that branch as soon as merged into master?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#22?email_source=notifications&email_token=AACZ7IL2VI4KFV6AL72TR6LP2ZDYHA5CNFSM4HYRIU6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZOBOQ#issuecomment-502456506>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACZ7INJZWPJLZE3NRRADWLP2ZDYHANCNFSM4HYRIU6A>
.
--
- Michael Please pardon any errors, this message was sent from my iPhone.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for new issue.
Summary of Changes
See joomla/joomla-cms#25234.
ini_get returns string "0" or "1" or whatever, which has to be type-casted to int before bitwise and.
Testing Instructions
Code review and read joomla/joomla-cms#25234.
Documentation Changes Required
None.