Skip to content

Appeasing Appveyor#25234

Closed
Hackwar wants to merge 1 commit intojoomla:stagingfrom
Hackwar:patch-9
Closed

Appeasing Appveyor#25234
Hackwar wants to merge 1 commit intojoomla:stagingfrom
Hackwar:patch-9

Conversation

@Hackwar
Copy link
Copy Markdown
Member

@Hackwar Hackwar commented Jun 16, 2019

Hopefully makeing Appveyor happy again.

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Jun 16, 2019

When this helps we should also patch this upstream in the string package: https://github.com/joomla-framework/string/blob/master/src/phputf8/utf8.php#L45 it seams some other changes have been done there in the meantime too.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Jun 16, 2019

It seems before making Appveyor happy it needs to wake him up.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Jun 16, 2019

Hooray, appveyor passed with success!!!

@richard67
Copy link
Copy Markdown
Member

richard67 commented Jun 16, 2019

I have tested this item ✅ successfully on 264fd78

Before this PR, Appveyor tests failed here:
https://github.com/joomla/joomla-cms/blob/staging/libraries/vendor/joomla/string/src/phputf8/utf8.php#L38
with error

Warning: A non-numeric value encountered in C:\projects\joomla-cms\libraries\vendor\joomla\string\src\phputf8\utf8.php on line 38

With this PR is passes.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25234.

This was referenced Jun 16, 2019
Closed
Merged
@richard67
Copy link
Copy Markdown
Member

richard67 commented Jun 16, 2019

@zero-24 PR for framwork package see joomla-framework/string#22.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Jun 16, 2019 •
edited
Loading

@zero-24 Does it need another PR in the framework package for the 2.0-dev branch? No, clarified.

@Hackwar
Copy link
Copy Markdown
Member Author

Hackwar commented Jun 16, 2019

Since this is the wrong way to fix this, I'm closing this one.

@Hackwar Hackwar closed this Jun 16, 2019
@richard67 richard67 mentioned this pull request Jun 16, 2019
Merged
@Hackwar Hackwar deleted the patch-9 branch June 16, 2019 21:03
@richard67
Copy link
Copy Markdown
Member

richard67 commented Jun 16, 2019

@Hackwar Please check PR #25243 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Composer Dependency Changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hackwar @zero-24 @richard67 @joomla-cms-bot