Skip to content

Dublicate Template Styles#93

Closed
hieblmedia wants to merge 6 commits intojoomla:masterfrom
hieblmedia:master
Closed

Dublicate Template Styles#93
hieblmedia wants to merge 6 commits intojoomla:masterfrom
hieblmedia:master

Conversation

@hieblmedia
Copy link
Copy Markdown
Contributor

Dublicate template styles if other type of extension exists with the same name.

I have added a filter with type=template for the query.

Also affected is the form field templatestyles, see:
joomla/joomla-platform#761

See http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27780

@infograf768
Copy link
Copy Markdown
Member

Please post issue in the tracker.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you use

$query->where($db->quoteName('e.type') . '='  . $db->quote('template'));

because 'type' could be a reserved word in some db engine

@hieblmedia
Copy link
Copy Markdown
Contributor Author

Moved templatestyle form field, from plattform to cms library.
See: joomla/joomla-platform#761 (comment)

@hieblmedia
Copy link
Copy Markdown
Contributor Author

I have reverted the commit to add the templatestyle form field. Because it is handled by the platform repository.

joomla/joomla-platform#761 (comment)
joomla/joomla-platform#814

@hieblmedia
Copy link
Copy Markdown
Contributor Author

Fxied in 4631a2d

@hieblmedia hieblmedia closed this Mar 5, 2012
infograf768 pushed a commit to infograf768/joomla-cms that referenced this pull request Aug 7, 2012
Fix #36 bootstrap/mootools conflicts with a patched bootstrap
elinw added a commit that referenced this pull request Jun 1, 2013
wilsonge pushed a commit that referenced this pull request Jan 23, 2017
* Add Preview Article button

* removed deprecated function params

* Added support for modal size

* Fix iframe height

* Set modal dimensions for article preview

* Re-compile SCSS
wilsonge pushed a commit that referenced this pull request Jan 23, 2017
wilsonge added a commit that referenced this pull request Jan 23, 2017
yvesh pushed a commit to yvesh/joomla-cms that referenced this pull request Jun 18, 2017
Adding extension tests execution in Builds
bembelimen referenced this pull request in bembelimen/joomla-cms Apr 26, 2018
Remove unneeded description
wilsonge pushed a commit to wilsonge/joomla-cms that referenced this pull request May 26, 2019
richard67 pushed a commit to richard67/joomla-cms that referenced this pull request Apr 3, 2020
Update fr-FR.com_patchtester.ini
HLeithner pushed a commit to HLeithner/joomla-cms that referenced this pull request May 10, 2020
* Add feature to the default workflow
Remove unnecessary stages (if s.o. wants J3 workflow => disable)

* Allow edit of core transition but only permissions

* Cleanup variable

* Disable different edit buttons for core workflow transitions
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
* Add feature to the default workflow
Remove unnecessary stages (if s.o. wants J3 workflow => disable)

* Allow edit of core transition but only permissions

* Cleanup variable

* Disable different edit buttons for core workflow transitions
obuisard added a commit to obuisard/joomla-cms that referenced this pull request Feb 21, 2023
* Missing search translation for the tour page

* Missing inputmode for search

* Missing inputmode for search
Wrong list ordering

* Missing permissions for tour

* Removed obsolete code

* URL field first as required

* Incomplete field attributes
Wrong naming of created/modified fields
Removed permissions fieldset

* Incomplete field attributes
Wrong naming of created/modified fields
Removed permissions fieldset

* tour_id should be filter_id

* Removed useless code

* Removed useless code

* Missing \

* Added message and removed buttons if tour is locked

* Renamed locked variable for consistency

* Renamed locked variable for consistency
Missing test on tour_id

* Removed useless extends

* Added prepareTable
Removed default which is not part of the data

* Added prepareTable
Removed useless code

* Note should be under the title

* Update step.xml

Typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants