Skip to content
This repository was archived by the owner on Nov 26, 2017. It is now read-only.

Joomla CMS [#27780] Fixed bug causing duplicate template styles in form field#761

Closed
hieblmedia wants to merge 2 commits intojoomla:stagingfrom
hieblmedia:master
Closed

Joomla CMS [#27780] Fixed bug causing duplicate template styles in form field#761
hieblmedia wants to merge 2 commits intojoomla:stagingfrom
hieblmedia:master

Conversation

@hieblmedia
Copy link
Copy Markdown
Contributor

Duplicate template styles if other type of extension exists with the same name.

I have added a filter with type=template for the query.

See http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27780

@hieblmedia
Copy link
Copy Markdown
Contributor Author

Also affected is the styles view in the component, see:
joomla/joomla-cms#93

@joomla-jenkins
Copy link
Copy Markdown

Unit testing complete. There were 0 failures and 0 errors from 1943 tests and 11087 assertions.
Checkstyle analysis reported 165 warnings and 0 errors.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you use

$query->where($db->quoteName('e.type') . '='  . $db->quote('template'));

because 'type' could be a reserved word in some db engine

@joomla-jenkins
Copy link
Copy Markdown

Build triggered by changes to the head.

Unit testing complete. There were 0 failures and 0 errors from 1941 tests and 11081 assertions.
Checkstyle analysis reported 165 warnings and 0 errors.

@infograf768
Copy link
Copy Markdown
Member

Test negative. See Tracker.

@eddieajau
Copy link
Copy Markdown
Contributor

The fix looks good. Since this is a CMS only field, would you also mind moving it from /libraries/joomla/ to /libraries/cms/. Thanks in advance.

@hieblmedia
Copy link
Copy Markdown
Contributor Author

I've added the file in the cms library.
See: joomla/joomla-cms#93 (commits)

I think on the platform this file should be deleted only in futher versions, for lecacy?

@realityking
Copy link
Copy Markdown
Contributor

The currently plan is not to actually move these files until Joomla 3.0. We just move classes we consider cms to the libraries/cms folder inside the platform repro.

@hieblmedia
Copy link
Copy Markdown
Contributor Author

Ok.

But now i can't commit in this pull request. I have created a new fork for a other pull request.
I am very new on github... It is required and recommended to create a new branch in my fork for each pull request?

@hieblmedia
Copy link
Copy Markdown
Contributor Author

I have created a new Pull Request: #814

@hieblmedia hieblmedia closed this Feb 1, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants