Skip to content

Adding Menu Title to menu items page#9227

Merged
wilsonge merged 1 commit intojoomla:stagingfrom
infograf768:menu_items_title
Feb 27, 2016
Merged

Adding Menu Title to menu items page#9227
wilsonge merged 1 commit intojoomla:stagingfrom
infograf768:menu_items_title

Conversation

@infograf768
Copy link
Copy Markdown
Member

@infograf768 infograf768 commented Feb 27, 2016

This PR will make it clear to which menu the menu items belong.

After patch:
screen shot 2016-02-27 at 08 56 00

@andrepereiradasilva #9218 (comment)
@richard67

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Feb 27, 2016
@ghost
Copy link
Copy Markdown

ghost commented Feb 27, 2016

I have tested this item ✅ successfully on 1c87b4c

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9227.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Feb 27, 2016

I have tested this item ✅ successfully on 1c87b4c

Nice, works like a charm here.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9227.

@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Feb 27, 2016

RTC. Thanks for testing.

If #8411 was ever considered, this would require a slight change as we would have no $menutype when displaying all menu items

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9227.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 27, 2016
@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Feb 27, 2016

I have tested this item ✅ successfully on 1c87b4c

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9227.

@brianteeman brianteeman mentioned this pull request Feb 27, 2016
Closed
@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Feb 27, 2016

If #8411 is accepted as well what is displayed in the title bar when you have "all menu itms" selected?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9227.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

andrepereiradasilva commented Feb 27, 2016

I have tested this item ✅ successfully on 1c87b4c

works fine.

One commnent. In the other views that have a view selector we use: xxxxxx - Site ou xxxxxx - Administrator, here we use xxxxxx (menu title).
IMHO the other views should be updated to follow this logic, ex:

  • Maintenance: Clear Cache (Site)
  • Maintenance: Clear Cache (Administrator)
  • Modules (Site)
  • Modules (Administrator)
  • Languages: Installed (Site)
  • Languages: Installed (Administrator)

Following the same logic everywhere is more user friendly.
What do you think?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9227.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Feb 27, 2016

I agree

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9227.

@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Feb 27, 2016

If #8411 is accepted as well what is displayed in the title bar when you have "all menu itms" selected?

it would be a new string, something like
Menus : All menu items

with a conditional

@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Feb 27, 2016

Merging this. JM #8411 will need to be updated after this

wilsonge added a commit that referenced this pull request Feb 27, 2016
@wilsonge
Merge pull request #9227 from infograf768/menu_items_title
5ae8bc3 
Adding Menu Title to menu items page
@wilsonge wilsonge merged commit 5ae8bc3 into joomla:staging Feb 27, 2016
@wilsonge wilsonge added this to the Joomla! 3.5.0 milestone Feb 27, 2016
@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Feb 27, 2016

Instead of updating #8411 I created a new PR #9231

Concerning the parenthesis, no objection.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 27, 2016
@andrepereiradasilva
Copy link
Copy Markdown
Contributor

andrepereiradasilva commented Feb 27, 2016

ok. will do a PR for that

@andrepereiradasilva andrepereiradasilva mentioned this pull request Feb 27, 2016
Merged
@infograf768 infograf768 deleted the menu_items_title branch April 17, 2016 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

Joomla! 3.5.0

Development

Successfully merging this pull request may close these issues.

6 participants

@infograf768 @richard67 @brianteeman @andrepereiradasilva @wilsonge @joomla-cms-bot