Skip to content

[Imp] Creating an All Menu dropdown in menu manager#9231

Closed
infograf768 wants to merge 7 commits intojoomla:stagingfrom
infograf768:menumanager2
Closed

[Imp] Creating an All Menu dropdown in menu manager#9231
infograf768 wants to merge 7 commits intojoomla:stagingfrom
infograf768:menumanager2

Conversation

@infograf768
Copy link
Copy Markdown
Member

@infograf768 infograf768 commented Feb 27, 2016

This PR to replace obsolete #8411
@brianteeman
@bertmert
@sural98
@andrepereiradasilva

To test on staging.

Only change vs #8411 is the Toolbar Title:
screen shot 2016-02-27 at 18 02 02

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 0605b12

Works fine.

I just have a consistency problem with this change.

In all other views, there is only one field (let's call it selector) that, is not inside the "Search filters": the client (or location). And this only exist in modules, cache and installed languages views.

That i know of, this is the only view that as a different selector: the menutype, but, if you have "- Select Menu -" option in theory is not a selector anymore as status, access, language and max levels are not. IMHO it turns itself into a search filter. And in that logic it should go inside search filters.
See, for instance, the example of the categories filter in articles view ...

PS: I know that this can be controversal. And don't want to hijack this PR with this, just leaving the thought here.

Marking as tested successfully as this PR works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

@infograf768
Copy link
Copy Markdown
Member Author

As most operations and simple structure comprehension in this manager imply selecting a specific menu, I think we should keep the Select Menu separate.

@richard67
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 0605b12


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

@infograf768
Copy link
Copy Markdown
Member Author

Thanks for testing. Bad luck this would be in 3.6.0 only :)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 29, 2016
@ghost
Copy link
Copy Markdown

ghost commented Mar 3, 2016

I have tested this item 🔴 unsuccessfully on 0605b12

- BE > Menu item manager.

  • Select a menu in dropdown select box.
  • In column Status click a button to unpublish a menu item.
  • Select box always falls back to entry "-Select menu--" and all menu items are shown.

Expected:

@infograf768
Copy link
Copy Markdown
Member Author

@bertmert
I confirm the issue. Taking off RTC for now.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 4, 2016
@joomla-cms-bot
Copy link
Copy Markdown

This PR has received new commits.

CC: @andrepereiradasilva, @bertmert, @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

@infograf768
Copy link
Copy Markdown
Member Author

I have already a solution for setdefault Home which I am now merging.

To solve the publishing state, I did not find any other solution than overriding legacy/controller/admin.php publish() method.
If someone has a better idea, please let me know.

@joomla-cms-bot
Copy link
Copy Markdown

This PR has received new commits.

CC: @andrepereiradasilva, @bertmert, @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

@infograf768
Copy link
Copy Markdown
Member Author

Now the publish() method is overriden. remains the Check-in one.

@joomla-cms-bot
Copy link
Copy Markdown

This PR has received new commits.

CC: @andrepereiradasilva, @bertmert, @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

@infograf768
Copy link
Copy Markdown
Member Author

Please test again all toolbar buttons and Status icons. Issues should be now solved.

@joomla-cms-bot
Copy link
Copy Markdown

This PR has received new commits.

CC: @andrepereiradasilva, @bertmert, @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

@joomla-cms-bot
Copy link
Copy Markdown

This PR has received new commits.

CC: @andrepereiradasilva, @bertmert, @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

@ghost
Copy link
Copy Markdown

ghost commented Mar 4, 2016

Just a note here because I couldn't workout detailed and reproducable test instructions yet to open an issue.
For a longer time now (3.4.x, several installations) I see frequently a similiar behavior after login but always just once as far as I remember. Filters "forget" their first settings after some actions in list views (without this PR) and fall back to first entry.
Just a "maybe somewhow related" to #9231 (comment)

@infograf768
Copy link
Copy Markdown
Member Author

In the case here, some code was required (the changes just done i.e. adding JFactory::getApplication()->getUserState('com_menus.items.menutype') to be sure to redirect to the correct screen)

If you have experienced issues elsewhere, please create a new issue.
In the mean while, thanks for testing here (and find the issue ☺ ).
If OK for you now, please mark test as successful.

@ghost
Copy link
Copy Markdown

ghost commented Mar 4, 2016

I have tested this item ✅ successfully on 5205083


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

@grhcj
Copy link
Copy Markdown

grhcj commented Mar 4, 2016

I have tested this item ✅ successfully on 5205083


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

@infograf768
Copy link
Copy Markdown
Member Author

thanks for testing. rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 9, 2016
@brianteeman brianteeman added this to the Joomla 3.5.1 milestone Mar 10, 2016
@brianteeman brianteeman modified the milestones: Joomla 3.5.1, Joomla 3.5.2 Mar 22, 2016
@rdeutz rdeutz modified the milestones: Joomla! 3.6.0, Joomla 3.5.2 Apr 12, 2016
@rdeutz
Copy link
Copy Markdown
Contributor

rdeutz commented Apr 12, 2016

looks for me like a new feature, changing Milestone to 3.6.

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Apr 12, 2016

if there is the decision that this is a new feature can we have a New feature label here than? @rdeutz

@ggppdk
Copy link
Copy Markdown
Contributor

ggppdk commented Apr 12, 2016

I have tested this item ✅ successfully on 5205083


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

1 similar comment
@MDXBilal12
Copy link
Copy Markdown

I have tested this item ✅ successfully on 5205083


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231.

@rdeutz
Copy link
Copy Markdown
Contributor

rdeutz commented May 2, 2016

@infograf768 cloud you please check the merge conflicts, thanks

@infograf768
Copy link
Copy Markdown
Member Author

Hmm. I must have deleted my local instance of this branch.
Here is a new PR conflicts solved.
#10190

I close this one.

@infograf768 infograf768 closed this May 2, 2016
@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented May 2, 2016

@brianteeman @rdeutz can you remove the RTC label and the milestone?

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 2, 2016
@rdeutz rdeutz removed this from the Joomla! 3.6.0 milestone May 2, 2016
@rdeutz rdeutz removed Language Change This is for Translators Feature labels May 2, 2016
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators labels May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.