[Imp] Creating an All Menu dropdown in menu manager#9231
[Imp] Creating an All Menu dropdown in menu manager#9231infograf768 wants to merge 7 commits intojoomla:stagingfrom
Conversation
|
I have tested this item ✅ successfully on 0605b12 I just have a consistency problem with this change. In all other views, there is only one field (let's call it selector) that, is not inside the "Search filters": the client (or location). And this only exist in modules, cache and installed languages views. That i know of, this is the only view that as a different selector: the menutype, but, if you have "- Select Menu -" option in theory is not a selector anymore as status, access, language and max levels are not. IMHO it turns itself into a search filter. And in that logic it should go inside search filters. PS: I know that this can be controversal. And don't want to hijack this PR with this, just leaving the thought here. Marking as tested successfully as this PR works as described. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231. |
|
As most operations and simple structure comprehension in this manager imply selecting a specific menu, I think we should keep the Select Menu separate. |
|
I have tested this item ✅ successfully on 0605b12 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231. |
|
Thanks for testing. Bad luck this would be in 3.6.0 only :) This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231. |
|
I have tested this item 🔴 unsuccessfully on 0605b12
Expected:
|
|
@bertmert This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231. |
|
This PR has received new commits. CC: @andrepereiradasilva, @bertmert, @richard67 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231. |
|
I have already a solution for setdefault Home which I am now merging. To solve the publishing state, I did not find any other solution than overriding legacy/controller/admin.php publish() method. |
|
This PR has received new commits. CC: @andrepereiradasilva, @bertmert, @richard67 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231. |
|
Now the publish() method is overriden. remains the Check-in one. |
|
This PR has received new commits. CC: @andrepereiradasilva, @bertmert, @richard67 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231. |
|
Please test again all toolbar buttons and Status icons. Issues should be now solved. |
|
This PR has received new commits. CC: @andrepereiradasilva, @bertmert, @richard67 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231. |
Fix code style
|
This PR has received new commits. CC: @andrepereiradasilva, @bertmert, @richard67 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231. |
|
Just a note here because I couldn't workout detailed and reproducable test instructions yet to open an issue. |
|
In the case here, some code was required (the changes just done i.e. adding If you have experienced issues elsewhere, please create a new issue. |
|
I have tested this item ✅ successfully on 5205083 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231. |
|
I have tested this item ✅ successfully on 5205083 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231. |
|
thanks for testing. rtc This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231. |
|
looks for me like a new feature, changing Milestone to 3.6. |
|
if there is the decision that this is a new feature can we have a |
|
I have tested this item ✅ successfully on 5205083 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231. |
1 similar comment
|
I have tested this item ✅ successfully on 5205083 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9231. |
|
@infograf768 cloud you please check the merge conflicts, thanks |
|
Hmm. I must have deleted my local instance of this branch. I close this one. |
|
@brianteeman @rdeutz can you remove the RTC label and the milestone? |
This PR to replace obsolete #8411
@brianteeman
@bertmert
@sural98
@andrepereiradasilva
To test on staging.
Only change vs #8411 is the Toolbar Title:
