Load mootools modal in layouts only if needed#7167
Merged
mbabker merged 1 commit intojoomla:stagingfrom Jul 11, 2015
dgrammatiko:__more_mootools
Merged
Load mootools modal in layouts only if needed#7167mbabker merged 1 commit intojoomla:stagingfrom dgrammatiko:__more_mootools
mbabker merged 1 commit intojoomla:stagingfrom
dgrammatiko:__more_mootools
Conversation
Contributor
|
#Test OK One step closer to drop mootools. Congratlations! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7167. |
Contributor
|
In addition, #7152 is closed and I didn't apply it for the test This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7167. |
Contributor
Author
|
@anibalsanchez A new replacement for #7152 will come soon! |
Contributor
|
@DGT41 can we RTC or do we need to test also on the replacement for #7152 bevor RTC? This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7167. |
Contributor
Author
|
@zero-24 you can RTC it |
Contributor
|
RTC 😄 Thanks! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7167. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conservative loading of mootools modal
Core editor xtd plugins call mootools modal way to early in the process, but we can differ this to layout and actually load it only if the plugin is actually a modal!
This should be 100% B/C
TESTING
Apply this patch and create a new Article. Observe any console error and that functionality of all buttons remains the same!
Apply also #7152, #5871, #5655, #5654 and try to create a new article. Observe that no mootools is loaded! Test functionality
Install some 3rd party dev xtd plugins and try their functionality and look for console logged errors