Skip to content

[#33445] RTL Chosen Select causes the page to disappear#7106

Closed
demis-palma wants to merge 1 commit intojoomla:stagingfrom
demis-palma:patch-2
Closed

[#33445] RTL Chosen Select causes the page to disappear#7106
demis-palma wants to merge 1 commit intojoomla:stagingfrom
demis-palma:patch-2

Conversation

@demis-palma
Copy link
Copy Markdown
Contributor

@demis-palma demis-palma commented Jun 3, 2015 •
edited
Loading

This PR fixes a long time known problem already confirmed, but still present.

How to reproduce

The bug affects Google Chrome, Firefox and Internet Explorer. Opera browser is not affected.

  • On "Template Manager", set Beez3 as default front-end template, which makes easier to reproduce the problem. Edit: This does not only affect Beez3, but a lot of third party templates as well.
  • On "Language Manager", set an RTL language as default front-end language, such as "Arabic", or "Hebrew". Edit: As per Brian's suggestion, it is not necessary to actually use Arabic language, you can just set <rtl>1</rtl> in language/en-GB/en-GB.xml to get English behave RTL.
  • Browse a page on your site containing at least one "select" component, the Archived Articles view is perfect for this purpose. index.php?option=com_content&view=archive
  • Open the "Select Month" dropdown. It is the rightmost. As soon as you choose an item, the most of the page elements disappear.
  • Reload the page.
  • Now open the pagination dropdown, which is the leftmost. Here the bug appears as soon as you open the dropdown. The problem is slightly different since it doesn't contain the search input-box.

When testing this patch, ensure to clear the cache of your browser and load the fixed css.

@joomla-cms-bot joomla-cms-bot changed the title RTL Chosen Select causes the page to disappear [#33445] RTL Chosen Select causes the page to disappear Jun 3, 2015
@zero-24 zero-24 removed the PR-staging label Jun 3, 2015
@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jun 5, 2015

Note for testers it is not necessary to install arabic language just can just change the value of

0
in en-GB.xml to 1

Before

Issue confirmed

After

Issue resolved

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7106.

@dgrammatiko
Copy link
Copy Markdown
Contributor

dgrammatiko commented Jun 5, 2015

@demis-palma You are editing an external resource here, I think those changes should be applied to the template(s)

@demis-palma
Copy link
Copy Markdown
Contributor Author

demis-palma commented Jun 5, 2015

media/jui/css/chosen.css is bundled with Joomla.
Can you define "external"?

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jun 5, 2015

We have updated this file before and iirc we are not using the current
release but an unmaintained version due to bootstrap 2 compatibiity issues
so I see no reason that we do not apply this PR

On 5 June 2015 at 23:25, Demis Palma notifications@github.com wrote:

media/jui/css/chosen.css is bundled with Joomla.
Can you define "external"?

—
Reply to this email directly or view it on GitHub
#7106 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@dgrammatiko
Copy link
Copy Markdown
Contributor

dgrammatiko commented Jun 5, 2015

@brianteeman thanks! So disregard my previous comment

@demis-palma
Copy link
Copy Markdown
Contributor Author

demis-palma commented Jun 5, 2015

From what I know, the original version from chosen bootstrap project, does not contain anything about RTL. The RTL implementation has been made by Joomla, but it is partial, therefore it causes problems.
Additional minor issues are still present, but currently I don't have the time to fix them.
I suggested to test beez tempalte because is bundled with Joomla, but I've noticed a lot of other third party tempaltes affected.

The bug is basically in this file, and therefore should be fixed in this file.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jun 5, 2015

Yes that is correct - we need to fix it in our own version of chosen.css

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7106.

@dgrammatiko
Copy link
Copy Markdown
Contributor

dgrammatiko commented Jun 5, 2015

@test ok
isis didn’t break
screenshot 2015-06-06 01 39 29
Beez renders ok
screenshot 2015-06-06 01 43 06

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jun 5, 2015

Thanks - setting RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7106.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Jun 5, 2015
@wilsonge wilsonge added this to the Joomla! 3.4.2 milestone Jun 10, 2015
@wilsonge wilsonge closed this in 1083ea5 Jun 11, 2015
johanjanssens pushed a commit to joomlatools/joomla-fork that referenced this pull request Jun 19, 2015
@demis-palma @johanjanssens
[Fix] Chosen select has issues in RTL languages
291a225 
Fixes joomla#7106
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
@demis-palma demis-palma deleted the patch-2 branch February 28, 2016 14:15
@demis-palma demis-palma mentioned this pull request Jun 6, 2017
Merged
@demis-palma
Copy link
Copy Markdown
Contributor Author

demis-palma commented Jun 6, 2017

I need someone to confirm this PR once again. See #16552

PS: @DGT41 was terribly right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla! 3.4.2

Development

Successfully merging this pull request may close these issues.

6 participants

@demis-palma @brianteeman @dgrammatiko @wilsonge @zero-24 @joomla-cms-bot