RTL Chosen Select causes the page to disappear by demis-palma · Pull Request #16552 · joomla/joomla-cms

demis-palma · 2017-06-06T21:20:25Z

This fixes once again the problem explained in #7106 which has returned after #11779

@DGT41 was right. If we plan to further update the chosen codebase, we should move the hacks (if possible) into a different file.

brianteeman · 2017-06-08T22:17:23Z

Is this the same issue as #13861 reported by @PhilETaylor - sorry I cant test

demis-palma · 2017-06-08T22:39:01Z

To me it's a different problem. I have reproduced it on Widows with Google Chrome, Firefox and Internet Explorer. Opera browser is not affected.

demis-palma · 2017-06-08T22:40:11Z

@brianteeman you confirmed the issue the last time #7106 (comment)

Saeedghb · 2018-09-26T15:23:59Z

Thank you @demis-palma

I had the same problem with the front-end select lists in rtl mode.
The issue can be verified by choosing beez3 as default template in front-end.

This commit fixed my problem.

infograf768 · 2018-09-26T15:40:20Z

has this been solved in staging?

sinahaghparast · 2018-10-27T12:04:58Z

Hello,

It's work...

Apply the chzn-rtl class on your select
github.com/harvesthq/chosen/issues/1056#issuecomment-13942263

Chosen already supports right to left select boxes. just add chosen-rtl to your select tags:
github.com/harvesthq/chosen/issues/1737#issuecomment-32887958 ==========

Saeedghb · 2018-10-28T20:28:37Z

@sinahaghparast
As I tested, neither class="chzn-rtl" nor class="chosen-select chosen-rtl" does not solve the problem with Joomla! 3.8.12 and beez3 template.

Did you test it with beez3 template?

sinahaghparast · 2018-10-31T12:26:48Z

when you load list form... Joomla load media/jui/css/chosen.css automaticly...
which template is not important...

in this file at line 368 you can see,
.chzn-rtl {
text-align: right;
}

We are together...

Saeedghb · 2021-06-06T10:47:22Z

@sinahaghparast

Of course I can see the above mentioned code, but adding "chzn-rtl" class to select list does not solve the problem.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16552.}

Saeedghb · 2021-06-07T13:46:04Z

The problem is present with K2 filter module.
This commit does not solve the problem.

brianteeman · 2021-06-07T13:47:36Z

best to ask the makers of k2 for problems with k2

Saeedghb · 2021-06-10T05:52:45Z

best to ask the makers of k2 for problems with k2

@brianteeman

This problem is not unique to K2. It is caused by a version of chozen used in Joomla!

laoneo · 2022-03-18T07:18:56Z

Does the issue still exists with the current Joomla 3 code base only (without K2)? If not then it got solved along the line since this pr was created.

brianteeman · 2022-03-18T08:56:43Z

Yes it still exists. Easy to test using the instructions from the linked issues

brianteeman · 2022-03-18T09:02:30Z

I have tested this item ✅ successfully on ed2cd13

forgot to add that the pr solves the issue

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16552.}

laoneo · 2022-03-18T14:00:57Z

I have tested this item ✅ successfully on 79c08b7

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16552.}

richard67 · 2022-03-18T14:06:57Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16552.}

zero-24 · 2022-03-18T14:36:35Z

I'm aware that I'm late to this party beeing that old but why do we comment a CSS rule and not just remove it?

laoneo · 2022-03-18T16:06:52Z

I would also remove the comments.

richard67 · 2022-03-18T16:09:37Z

@zero-24 @laoneo So shall we remove RTC and add the"Updates Requested" label? I worry the author could not be available anymore for making changes.

media/jui/css/chosen.css

Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>

media/jui/css/chosen.css

zero-24 · 2022-03-18T16:18:16Z

Merging here thanks for the patience

[Fix] Chosen select has issues in RTL languages

ed2cd13

joomla-cms-bot added the PR-staging label Jun 6, 2017

This was referenced Jun 6, 2017

Chosen - upgrade #11779

Closed

Isis Retina - Dropdown icons fix #12528

Merged

[#33445] RTL Chosen Select causes the page to disappear #7106

Closed

joomla-cms-bot removed the PR-staging label Jun 7, 2017

brianteeman mentioned this pull request Aug 18, 2017

[3.7.0beta1] Installer Arabic Unitag WhiteScreen issue #13861

Closed

brianteeman added the PR-staging label Jul 22, 2018

ghost added the J3 Issue label Apr 5, 2019

ghost removed the J3 Issue label Apr 19, 2019

ghost changed the title ~~[Fix Regression] RTL Chosen Select causes the page to disappear~~ RTL Chosen Select causes the page to disappear Apr 19, 2019

zero-24 added PR-3.10-dev and removed PR-staging labels Aug 9, 2021

Quy added the Information Required label Mar 18, 2022

Quy removed the Information Required label Mar 18, 2022

Merge branch '3.10-dev' into chosen-rtl

79c08b7

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 18, 2022

zero-24 added this to the Joomla 3.10.7 milestone Mar 18, 2022

laoneo reviewed Mar 18, 2022

View reviewed changes

media/jui/css/chosen.css Outdated Show resolved Hide resolved

zero-24 reviewed Mar 18, 2022

View reviewed changes

media/jui/css/chosen.css Outdated Show resolved Hide resolved

Apply suggestions from code review

3febb02

Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>

zero-24 merged commit 417cbb7 into joomla:3.10-dev Mar 18, 2022

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 18, 2022

laoneo reviewed Mar 18, 2022

View reviewed changes

media/jui/css/chosen.css Outdated Show resolved Hide resolved

Uh oh!

Conversation

demis-palma commented Jun 6, 2017 • edited by joomla-cms-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianteeman commented Jun 8, 2017

Uh oh!

demis-palma commented Jun 8, 2017

Uh oh!

demis-palma commented Jun 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Saeedghb commented Sep 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

infograf768 commented Sep 26, 2018

Uh oh!

sinahaghparast commented Oct 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Saeedghb commented Oct 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sinahaghparast commented Oct 31, 2018

in this file at line 368 you can see, .chzn-rtl { text-align: right; }

Uh oh!

Saeedghb commented Jun 6, 2021

Uh oh!

Saeedghb commented Jun 7, 2021

Uh oh!

brianteeman commented Jun 7, 2021

Uh oh!

Saeedghb commented Jun 10, 2021

Uh oh!

laoneo commented Mar 18, 2022

Uh oh!

brianteeman commented Mar 18, 2022

Uh oh!

brianteeman commented Mar 18, 2022

Uh oh!

laoneo commented Mar 18, 2022

Uh oh!

richard67 commented Mar 18, 2022

Uh oh!

zero-24 commented Mar 18, 2022

Uh oh!

laoneo commented Mar 18, 2022

Uh oh!

richard67 commented Mar 18, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zero-24 commented Mar 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

demis-palma commented Jun 6, 2017 •

edited by joomla-cms-bot

Loading

demis-palma commented Jun 8, 2017 •

edited

Loading

Saeedghb commented Sep 26, 2018 •

edited

Loading

sinahaghparast commented Oct 27, 2018 •

edited

Loading

Saeedghb commented Oct 28, 2018 •

edited

Loading

in this file at line 368 you can see,
.chzn-rtl {
text-align: right;
}