Conversation
…separated old extraction logic from streaming logic.
|
For some reason this didn't get tagged and TCI wasn't initiated. Is Bzip2 on the exclude list? |
|
Nothing should be on the exclude list. I'll try and work out what's going on! |
|
It started up after I pushed a few style fixes. I'm guessing it was just a hiccup in TCI |
|
Looks good to me. We won't add this in the 3.4.1 but after another successful test we can merge it for the 3.4.2 version. Thank you @Mathewlenning! |
There was a problem hiding this comment.
Why do you unset this here? Shouldn't this be set to null or something?
There was a problem hiding this comment.
That is the original behavior. Changing an established side effect without a good reason doesn't make sense. Setting it to null has no benefit to cleanliness or clarity, but it does present the possibility of breaking something if someone was expecting it to be unset.
|
Thank you @Mathewlenning! |
…leanup-installer-plugins * 'staging' of https://github.com/joomla/joomla-cms: Smart Search: utf8_strpos: Offset must be an integer (joomla#10303) Removed an redundant else clause from JFeedParser::processElement (joomla#7961) CLEANING-JDataSet (joomla#7947) CLEANING-JAdapter (joomla#6679) Same treatment as JArchiveBzip2 and JArchiveGzip (joomla#6515) Cleaning up JArchiveBzip2 (joomla#6495) Removed the nested conditional switch construct (joomla#6338) add edit tooltip to modules (joomla#10295) New installer plugins: remove the dot in the plugin name and other language review (joomla#10299)
Isolated JError into temporary method and separated old extraction logic from streaming logic.
I'm not sure where this is used, but most likely in the installer.
I did a find usage with PHPStorm, but the only results I got where from the unit tests.
So if anyone knows where it is used could you let me know.