Skip to content

New installer plugins: remove the dot in the plugin name and other language review#10299

Merged
wilsonge merged 3 commits intojoomla:stagingfrom
andrepereiradasilva:installer-plugin-name
May 8, 2016
Merged

New installer plugins: remove the dot in the plugin name and other language review#10299
wilsonge merged 3 commits intojoomla:stagingfrom
andrepereiradasilva:installer-plugin-name

Conversation

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

@andrepereiradasilva andrepereiradasilva commented May 8, 2016

Summary of Changes

Small changes in the new "Install from URL or Path Folder" plugin language file.

  • Removes the dot in the plugin name (for consistency with all others)
  • Add the plugin name in the main language file
  • Alpha order the language strings

Testing Instructions

Code review.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels May 8, 2016
@andrepereiradasilva andrepereiradasilva changed the title New "Install from URL or Path Folder": remove the dot in the plugin name New "Install from URL or Path Folder": remove the dot in the plugin name and other May 8, 2016
@andrepereiradasilva andrepereiradasilva changed the title New "Install from URL or Path Folder": remove the dot in the plugin name and other New installer plugins: remove the dot in the plugin name and other language review May 8, 2016
@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented May 8, 2016

I have tested this item ✅ successfully on 9746c0c

Looks good to me @brianteeman can you have a final look?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10299.

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 9746c0c


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10299.

@brianteeman
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10299.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 8, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 8, 2016
@wilsonge wilsonge merged commit 69d4a8a into joomla:staging May 8, 2016
@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

thanks for testing, comments and merging!

@andrepereiradasilva andrepereiradasilva deleted the installer-plugin-name branch May 8, 2016 09:55
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 8, 2016
roland-d added a commit to roland-d/joomla-cms that referenced this pull request May 8, 2016
…leanup-installer-plugins

* 'staging' of https://github.com/joomla/joomla-cms:
  Smart Search: utf8_strpos: Offset must be an integer (joomla#10303)
  Removed an redundant else clause from JFeedParser::processElement (joomla#7961)
  CLEANING-JDataSet (joomla#7947)
  CLEANING-JAdapter (joomla#6679)
  Same  treatment as JArchiveBzip2 and JArchiveGzip (joomla#6515)
  Cleaning up JArchiveBzip2 (joomla#6495)
  Removed the nested conditional switch construct (joomla#6338)
  add edit tooltip to modules (joomla#10295)
  New installer plugins: remove the dot in the plugin name and other language review (joomla#10299)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants