Allow toolbar popup buttons use bootstrap footer#6462
Closed
dgrammatiko wants to merge 5 commits intojoomla:stagingfrom
dgrammatiko:_bs_footer_for_toolbar_btn
Closed
Allow toolbar popup buttons use bootstrap footer#6462dgrammatiko wants to merge 5 commits intojoomla:stagingfrom dgrammatiko:_bs_footer_for_toolbar_btn
dgrammatiko wants to merge 5 commits intojoomla:stagingfrom
dgrammatiko:_bs_footer_for_toolbar_btn
Conversation
Contributor
|
@test Looks good on desktop, on mobile layout the buttons fall over each other |
Contributor
|
Just tested it. It works fine! |
Contributor
|
Should we move this RTC? Two good tests |
Contributor
Author
|
@zero-24 can we RTC this one? |
Contributor
|
Thanks for the bump 😄 RTC now This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6462. |
Contributor
|
@committer please be sure that #4563 is merged bevor this as this is a requirement. |
johanjanssens
pushed a commit
to joomlatools/joomla-fork
that referenced
this pull request
Jun 19, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow custom footer on BS modals rendered from toolbar button
This is a new feature requested at #4563
What it does?
Allows to render modal in the bootstrap official way, where the buttons are on the bottom of the modal window
How to test
Apply this patch and #4563
Change line 83 of administrator/components/com_messages/views/messages/view.html.php to
You should get:
Mind that the buttons are fake, no functionality is attached