Fix for Page Navigation Plugin on User Auth View#5698
Merged
Kubik-Rubik merged 2 commits intojoomla:stagingfrom Jan 13, 2015
pe7er:patch-3
Merged
Fix for Page Navigation Plugin on User Auth View#5698Kubik-Rubik merged 2 commits intojoomla:stagingfrom pe7er:patch-3
Kubik-Rubik merged 2 commits intojoomla:stagingfrom
pe7er:patch-3
Conversation
Fix for issue: #5685 The Article Pagination "Prev" & "Next" used the current article's Access Level (with "AND a.access = ' . (int) $row->access)") to navigate among articles within the same Category. That caused problems with Articles from the same Category that had different Access Levels. This fix checks the User's authorized Access Levels (with "AND a.access IN ('.implode(",", JAccess::getAuthorisedViewLevels($user->id)).') ')" instead. Note: using "IN" in SQL queries might be slower than "equal". I have not tested this fix on categories with huge numbers of articles!
Contributor
|
You forget to make spaces before and after "." could you fix that to make travis happy, Thanks :-) |
Contributor
Author
|
Ah, I noticed the Travis error but did not know the cause. |
Fixed code style (spaces around the concatenating dots). Travis was not happy with my 1st PR #5698
Member
|
@test successfull |
Member
|
Thank you @pe7er, this PR fixes the problem. I will merge the PR and close it! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5698. |
Kubik-Rubik
added a commit
that referenced
this pull request
Jan 13, 2015
Fix for Page Navigation Plugin on User Auth View
Contributor
Author
|
Great! Thank you all for testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue: #5685 (see that issue for testing instruction)
The Article Pagination "Prev" & "Next" used the current article's Access Level (with "AND a.access = ' . (int) $row->access)") to navigate among articles within the same Category. That caused problems with Articles from the same Category that had different Access Levels.
This fix checks the User's authorized Access Levels (with "AND a.access IN ('.implode(",", JAccess::getAuthorisedViewLevels($user->id)).') ')" instead.
Note: using "IN" in SQL queries might be slower than "equal". I have not tested this fix on categories with huge numbers of articles!