I have tested this item ✅ successfully on 56818f4

I have tested this successfully! Thanks @heelc29!

I have zero confidence in this PR. The first version had three breaking changes. Two were spotted before it was merged. A third was only spotted after it was merged.

@heelc29 Could you check and update your testing instructions? They tell about the ternary shortcut ?:, but your code does not use that, it uses a ternary with !empty() condition (which is right, I think).

I have tested this item ✅ successfully on 56818f4

Tested this and it worked.

I just had a quick look at the original PR and saw that it has a potential issue. You had to change some class properties to public like this one https://github.com/joomla/joomla-cms/pull/45702/files#diff-c0ddd6d01f117db59d8e37f1e2a6b44d1ac9718e480790c5d25650fbfa939043R38 mean third party extensions have this property defined as protected will be broken

The deprecation to AbstractView::get method is also questionable. It prevents access to private or protected data of view classes in the layouts (causes the change you had to made in that PR), so I even unsure if that deprecation is valid.

@joomdonation What do you suggest? Revert the original PR completely, like it would have been done with PR #45940 ?

Clearly that PR was wrong

@richard67 We will need to discuss first to see if we really want to deprecate AbstractView::get method before making further decision. If we still want to deprecate that method, the the completely revert is not needed but we will have to fix all backward incompatible changes.

@joomdonation Well, the deprecation says it will be removed in 7.0, so we could revert the initial PR, which would mean 5.4 and 6.0 would still use deprecated code, not nice but allowed. That would give us more time to decide about the deprecation, if we remove it or only move it from 7 to 8. Beta 2 is not far away, so we might not have the time for long discussions.

@richard67 If so, revert original PR would work.

Only not nice if the depreciation was valid in the first place. To me it's something that was done without any consideration of the consequences which we are now seeing

To me, the depreciation was not very well thought. I understand that we want to call model methods directly to get data and pass it to the view but we didn't care about the case it is used to allow access to none public property in the class https://github.com/joomla/joomla-cms/blob/5.3-dev/libraries/src/MVC/View/AbstractView.php#L175-L177

I just had a quick look at the original PR and saw that it has a potential issue. You had to change some class properties to public like this one https://github.com/joomla/joomla-cms/pull/45702/files#diff-c0ddd6d01f117db59d8e37f1e2a6b44d1ac9718e480790c5d25650fbfa939043R38 mean third party extensions have this property defined as protected will be broken

That's why I asked @Hackwar for a comment (see description of original PR #45702)
as negative side effect #44162 the access to protected properties of the view class is no longer possible. Is that acceptable?

The deprecation to AbstractView::get method is also questionable. It prevents access to private or protected data of view classes in the layouts (causes the change you had to made in that PR), so I even unsure if that deprecation is valid.

I am also convinced that some code is marked as deprecated but is still used 100 times by the core.
Example CurrentUserTrait #45700

If so, revert original PR would work.

Let me know how to proceed from here.

I think for 5.4 we have to play safe and revert the initial PR #45702 completely.

@brianteeman Could you re-open your PR #45940 for that? If that is not possible, either make a new PR or let me know and I make one. Thanks in advance.

as it was closed by @chmst I do not have the access level required to re-open

as it was closed by @chmst I do not have the access level required to re-open

@brianteeman Thanks for restoring the branch. I've re-opened the PR. Made 2 CS suggestions.

For this PR here we (maintainers) will discuss if we will use it for 6.0-dev.

We (release managers and other maintainers) have decided to completely revert the b/c break in 5.4 and 6.0 for the upcoming beta 2 releases, and so we decided for PR #45940 , and this one here is obsolete for now.

It would have worked for the core, but might not have been sufficient for all 3rd party extension issues.

@heelc29 Thanks a lot for your efforts working on the issue. I's much appreciated.

Closing in favour of #45940 .