Skip to content

[5.x][6.x] Missing CurrentUser if model is created with MVCFactory #45700

Open
Open
[5.x][6.x] Missing CurrentUser if model is created with MVCFactory#45700
Labels
No Code Attached Yet
@heelc29

Description

@heelc29
heelc29
opened on Jul 7, 2025

Steps to reproduce the issue

If a Model, View, Table with the MVCFactory not all (required) options are injected to the objects eg. CurrentUserInterface because its injected by BaseController and not by the factory itself.

joomla-cms/libraries/src/MVC/Controller/BaseController.php

Lines 580 to 582 in 8868adc

if ($model instanceof CurrentUserInterface && $this->app->getIdentity()) {
$model->setCurrentUser($this->app->getIdentity());
}

joomla-cms/libraries/src/MVC/Controller/BaseController.php

Lines 611 to 613 in 8868adc

if ($view instanceof CurrentUserInterface && $this->app->getIdentity()) {
$view->setCurrentUser($this->app->getIdentity());
}

if you disabled this deprecated code

joomla-cms/libraries/src/User/CurrentUserTrait.php

Lines 43 to 49 in 8868adc

if (!$this->currentUser) {
@trigger_error(
\sprintf('User must be set in %s. This will not be caught anymore in 6.0', __METHOD__),
E_USER_DEPRECATED
);
$this->currentUser = Factory::getApplication()->getIdentity() ?: Factory::getUser();
}

Expected result

no additional injects necessary if model/view/table etc. is created with MVCFactory

Actual result

you get problems with this code

joomla-cms/modules/mod_articles/src/Helper/ArticlesHelper.php

Line 58 in 8868adc

$articles = $factory->createModel('Articles', 'Site', ['ignore_request' => true]);

joomla-cms/modules/mod_articles/src/Helper/ArticlesHelper.php

Line 278 in 8868adc

$items = $articles->getItems();

ping @laoneo

Metadata

Metadata

Assignees

No one assigned

    Labels

    No Code Attached Yet

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions