[5.4] Revert b/c breaking change in AbstractView::get#45940
[5.4] Revert b/c breaking change in AbstractView::get#45940muhme merged 5 commits intojoomla:5.4-devfrom
Conversation
…mla#45702)" This reverts commit f1906ba.
|
I have tested this item ✅ successfully on c714046 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45940. |
|
Please also check the alternative PR #45949 to fix the introduced b/c break instead of complete revert. |
|
This one here should be closed as it reintroduces deprecated code usage. |
|
Maintainers decided to not revert the whole PR but to fix it correctly. Please test #45949 |
|
I have made the requested changes - not sure why they were needed as it was a pure revert |
@brianteeman I don't see the requested changes here on GitHub. They are not needed for the complete revert of the PR, but it would be nice to keep the code style fixes from that PR. |
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
|
sorry I pressed the wrong button |
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
|
I've restored the previous test result from @exlemor 's test as the counter has only been invalidated due to closing the PR and clean branch updates. The code has not really changed. |
|
I have tested this item ✅ successfully on e9285fa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45940. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45940. |
|
Final test before merge, using JBT graft
|
|
Thank you @brianteeman for your contribution. Thank you @richard67 for your support. Thank you @heelc29 and @exlemor for your test. |
* [5.3] Translation Update (#45983) * Fix copy / paste error (#45979) * [5.3] Security updates for composer and npm dependencies for the upcoming 5.3.4 release (#45984) * composer update enshrined/svg-sanitize to 0.22.0 * npm fix audit issues * [5.3] Update TinyMCE from 6.8.5 to 6.8.6 to fix TinyMCE issue with cursor placement (#45987) * npm update tinymce from 6.8.5 to 6.8.6 * Update version in tinymce.xml * [5.4] Revert b/c breaking change in AbstractView::get (#45940) * Revert "[5.4] Replace deprecation AbstractView::get() in layouts (#45702)" * This reverts commit f1906ba. * [5.3] Update joomla/filesystem to fix extension uploads when post_max_size is 0 (#45986) * [5.4] Upmerge 2025-08-28 (#45997) * [5.3] Translation Update #45983 * [5.3] Fix copy / paste error in form fields #45979 * [5.3] Security updates for composer and npm dependencies for the upcoming 5.3.4 release #45984 * [5.3] Update joomla/filesystem to fix extension uploads when post_max_size is 0 #45986 * [5.4] Composer update joomla/filesystem to 3.2.0 (#45999) * Update content-hash
This reverts commit f1906ba from merged PR #45702 .
Summary of Changes
As can be seen in #45938 PR #45702 introduced a b/c breaking change that should not happen in a minor release.
Testing Instructions
Open a guided tour or guided tour step for editing and go to the publishing tab
Actual result BEFORE applying this Pull Request
The tab contains no fields
Expected result AFTER applying this Pull Request
The tab contains publishing related fields
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed