[5.1] Merge update parameter and improve contrain checker by bembelimen · Pull Request #43147 · joomla/joomla-cms

bembelimen · 2024-03-25T08:43:18Z

Pull Request for Issue #43100 .

Summary of Changes

With TUF testing channel is not needed anymore and should use the TUF behaviour. Also allow now explicit testing for "default" and "next"

Testing Instructions

Install Beta 1
Apply patch to beta 1
Go to joomla updater
Go to options and select "default" + "beta" for stability level
Update

Actual result BEFORE applying this Pull Request

Options not there, update does not work

Expected result AFTER applying this Pull Request

Update works

brianteeman · 2024-03-25T08:59:04Z

Should the code comments here be updated to include "testing"

joomla-cms/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php

Line 107 in ea1b3fb

    
                            * The commented "case" below are for documenting where 'default' and legacy options falls

libraries/src/Updater/ConstraintChecker.php

administrator/components/com_joomlaupdate/config.xml

MacJoom · 2024-03-26T13:27:55Z

I have tested this item ✅ successfully on ea1b3fb

From a 5.1 Beta 1 Installation. Without the patch i have the message 'This site can't be updated to Joomla 5.1.0-beta2 .... doesn't meet the minimum requirements...' - with the patch it works!

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43147.}

dautrich · 2024-03-26T14:34:06Z

I have tested this item ✅ successfully on ea1b3fb

Same behavior as described by @MacJoom

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43147.}

richard67 · 2024-03-26T15:26:42Z

RTC as this PR has 2 successful human tests. But it needs more fixes for the updater when using TUF. E.g. the channel ("5.x" or "6.x" depending on Default or Next update source) currently is currently not checked, as far as I can see, and there is one more place where we should use the minimumStability parameter independently from the selected update channel as suggested with my PR for this PR.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43147.}

MacJoom · 2024-03-26T15:57:37Z

I have tested both "default" and "next" channel. With the patch it works as expected for both channels. It gives different messages depending on the channel set. "next" channel offers the update to 5.1 beta 2.

LadySolveig · 2024-03-27T19:56:39Z

Thank you @bembelimen and for support to @richard67 and also for testing @MacJoom and @dautrich

joomla/joomla-cms#42966 - (только для en-GB) joomla/joomla-cms#42953 + joomla/joomla-cms#42986 + joomla/joomla-cms#42221 + joomla/joomla-cms#41659 + joomla/joomla-cms#43061 + joomla/joomla-cms#43054 - (только для en-GB) joomla/joomla-cms#42995 - (только для en-GB) joomla/joomla-cms#43115 + joomla/joomla-cms#43147 + + Upmerge

This deprecation was missed with joomla#43147 Signed-off-by: BrianTeeman <brian@teeman.net>

This deprecation was missed with #43147 Signed-off-by: BrianTeeman <brian@teeman.net>

bembelimen added 3 commits March 24, 2024 22:51

Make Joomla Updateable

cf6a8c3

Reset formatting

82adc4c

Remove comment

a59042a

bembelimen requested review from rdeutz and zero-24 as code owners March 25, 2024 08:43

joomla-cms-bot added the PR-5.1-dev label Mar 25, 2024

bembelimen added 2 commits March 25, 2024 09:54

Update ConstraintChecker.php

aa8ae79

Update UpdateModel.php

ea1b3fb

zero-24 reviewed Mar 25, 2024

View reviewed changes

libraries/src/Updater/ConstraintChecker.php Outdated Show resolved Hide resolved

zero-24 reviewed Mar 25, 2024

View reviewed changes

administrator/components/com_joomlaupdate/config.xml Show resolved Hide resolved

Quy mentioned this pull request Mar 25, 2024

[5.1.0_RC2] Checksum Error on Update #43150

Closed

richard67 mentioned this pull request Mar 25, 2024

[CMS PR 43147] Use the right minimum stability bembelimen/joomla-cms#133

Merged

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 26, 2024

richard67 and others added 6 commits March 27, 2024 17:32

[CMS PR 43147] Use the right minimum stability (#133)

31faa5e

Merge branch '5.1-dev' into tuf/update-fixes

d077554

Add testing as comment

c3f2301

Remove testing

1d6a489

Deprecate language string

0fba72e

Validate customurl for URL type

4e5ad25

joomla-cms-bot added the Language Change This is for Translators label Mar 27, 2024

bembelimen and others added 2 commits March 27, 2024 18:30

Remove filter as we only want valid URLs

c72d814

Merge branch '5.1-dev' into tuf/update-fixes

d4a1359

LadySolveig merged commit a9950a7 into joomla:5.1-dev Mar 27, 2024

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 27, 2024

bembelimen added this to the Joomla! 5.1.0 milestone Mar 27, 2024

jgerman-bot mentioned this pull request Mar 28, 2024

[5.1] Merge update parameter and improve contrain checker joomlagerman/joomla#3144

Closed

joomlapl-bot mentioned this pull request Mar 28, 2024

[5.1] Merge update parameter and improve contrain checker JoomlaPolska/jezyk-J4#484

Closed

brianteeman mentioned this pull request Jul 2, 2024

[5.1] CLI Update channel #43732

Closed

brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Jun 5, 2025

[5.4] Deprecate language string

2485a90

This deprecation was missed with joomla#43147 Signed-off-by: BrianTeeman <brian@teeman.net>

brianteeman mentioned this pull request Jun 5, 2025

[5.4] Deprecate language string #45564

Merged

muhme pushed a commit that referenced this pull request Jun 5, 2025

[5.4] Deprecate language string (#45564)

1a6c306

This deprecation was missed with #43147 Signed-off-by: BrianTeeman <brian@teeman.net>

bembelimen deleted the tuf/update-fixes branch December 9, 2025 08:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[5.1] Merge update parameter and improve contrain checker#43147

[5.1] Merge update parameter and improve contrain checker#43147
LadySolveig merged 13 commits intojoomla:5.1-devfrom
bembelimen:tuf/update-fixes

bembelimen commented Mar 25, 2024

Uh oh!

brianteeman commented Mar 25, 2024

Uh oh!

Uh oh!

Uh oh!

MacJoom commented Mar 26, 2024

Uh oh!

dautrich commented Mar 26, 2024 •

edited

Loading

Uh oh!

richard67 commented Mar 26, 2024

Uh oh!

MacJoom commented Mar 26, 2024

Uh oh!

LadySolveig commented Mar 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

bembelimen commented Mar 25, 2024

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Uh oh!

brianteeman commented Mar 25, 2024

Uh oh!

Uh oh!

Uh oh!

MacJoom commented Mar 26, 2024

Uh oh!

dautrich commented Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard67 commented Mar 26, 2024

Uh oh!

MacJoom commented Mar 26, 2024

Uh oh!

LadySolveig commented Mar 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

dautrich commented Mar 26, 2024 •

edited

Loading